Page MenuHomePhabricator

[lib] add getFCAvatarURLs method to NeynarClientProvider
ClosedPublic

Authored by varun on Aug 15 2024, 10:53 PM.
Tags
None
Referenced Files
F3188620: D13099.id44448.diff
Fri, Nov 8, 7:02 PM
F3188619: D13099.id43420.diff
Fri, Nov 8, 7:02 PM
F3188618: D13099.id44500.diff
Fri, Nov 8, 7:02 PM
F3188617: D13099.id44446.diff
Fri, Nov 8, 7:02 PM
F3188609: D13099.diff
Fri, Nov 8, 7:02 PM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Wed, Oct 30, 11:24 PM
Unknown Object (File)
Wed, Oct 30, 11:24 PM
Subscribers

Details

Summary

Based this off the existing client provider method for FC usernames

Deduping made this code harder to follow. That said, I can revise this if reviewers think it would be better anyway

Depends on D13098

Test Plan

tested at end of stack by successfully fetching farcaster avatar URL with neynar

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun held this revision as a draft.
varun edited the test plan for this revision. (Show Details)
varun edited the summary of this revision. (Show Details)
varun published this revision for review.Sep 18 2024, 6:43 AM
varun added reviewers: ashoat, tomek.
This revision is now accepted and ready to land.Sep 18 2024, 9:10 AM

use new base type for farcaster avatar URLs

varun added inline comments.
lib/utils/farcaster-helpers.js
125–127 ↗(On Diff #44446)

realized this can probably be removed

remove unnecessary condition

This revision is now accepted and ready to land.Sep 23 2024, 11:17 AM

i don't want this reviewed until i've finalized the whole stack

rebase and publish for review

This revision is now accepted and ready to land.Sep 24 2024, 2:44 PM
varun requested review of this revision.Sep 24 2024, 2:46 PM

sorry to request review again, but this changed considerably after addressing feedback later in stack

ashoat added inline comments.
lib/utils/farcaster-helpers.js
5–20 ↗(On Diff #44500)

Nit: I would change how these are grouped – group BaseFCNamesInfo / GetFCNames, and BaseFCAvatarInfo / GetFCAvatarURLs

Meanwhile the avatar stuff can be moved to above the definition of getFCAvatarURLs

This revision is now accepted and ready to land.Sep 24 2024, 4:00 PM