[lib] update getAvatarForUser signature
ClosedPublic
Actions

Authored by varun on Sep 24 2024, 8:49 AM.

Details

Reviewers

Commits

rCOMM9dc74fdfbfc6: [lib] update getAvatarForUser signature

Summary

getAvatarForUser just needs a type that contains optional, nullable username and avatar fields. modifying the function signature to make it clear what data we're dealing with here.

Test Plan

tested with rest of stack by successfully setting thread and user avatars

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Sep 24 2024, 8:49 AM

Herald added a subscriber: tomek. · View Herald TranscriptSep 24 2024, 8:49 AM

will add this to existing diff stack

Harbormaster completed remote builds in B31818: Diff 44486.Sep 24 2024, 9:13 AM

rebase and publish for review

varun added a parent revision: D13100: [native] add farcaster avatar URL to registration workflow.Sep 24 2024, 2:45 PM

varun added a child revision: D13101: [native] let user choose farcaster avatar.

Harbormaster completed remote builds in B31830: Diff 44502.Sep 24 2024, 3:01 PM

ashoat accepted this revision.Sep 24 2024, 4:02 PM

This revision is now accepted and ready to land.Sep 24 2024, 4:02 PM

Closed by commit rCOMM9dc74fdfbfc6: [lib] update getAvatarForUser signature (authored by varun). · Explain WhySep 25 2024, 7:24 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9dc74fdfbfc6: [lib] update getAvatarForUser signature.

Revision Contents
Changeset List

Path

Size

lib/

shared/

avatar-utils.js

12 lines

Diff 44544

View Options

lib/shared/avatar-utils.js

Show All 38 Lines	tracing::error!(
errorType = error_types::HTTP_LOG,		errorType = error_types::HTTP_LOG,
"Backup service failed to delete user data: {} - {}",		"Backup service failed to delete user data: {} - {}",
response_status,		response_status,
response_body,		response_body,
)		)
}		}
Ok(())		Ok(())
}		}

		pub async fn user_has_backup(
		user_identifier: &str,
		) -> Result<bool, crate::error::Error> {
		let path = format!("/backups/latest/{user_identifier}/backup_info");
		let url = CONFIG
		.backup_service_url
		.join(&path)
		.expect("failed to construct backup service URL");

		let client = reqwest::Client::builder().build()?;
		let response = client.get(url).send().await?;

		use http::StatusCode;
		match response.status() {
		StatusCode::OK => Ok(true), // Backup service returned backup info
		StatusCode::NOT_FOUND => Ok(false), // Backup service returned BackupError::NoBackup
		StatusCode::BAD_REQUEST => {
		// Identity has no user with given UserIdentifier
		Err(crate::error::Error::MissingItem)
		}
		response_status => {
		let response_body = response
		.text()
		.await
		.unwrap_or("[failed to get response text]".to_string());
		tracing::error!(
		errorType = error_types::HTTP_LOG,
		"Backup service failed to get latest backup info: {} - {}",
		response_status,
		response_body,
		);
		Err(
		tonic::Status::aborted(tonic_status_messages::UNEXPECTED_ERROR).into(),
		)
		}
		}
		}

[lib] update getAvatarForUser signatureClosedPublicActions