Page MenuHomePhabricator
Differential D13381

[native][web] make farcaster avatars work as thread avatars
Needs RevisionPublic
Actions

Authored by varun on Wed, Sep 18, 6:24 AM.
Tags
None
Referenced Files
F2761545: D13381.id.diff
Thu, Sep 19, 8:36 AM
F2758607: D13381.id.diff
Thu, Sep 19, 4:05 AM
F2756180: D13381.id44300.diff
Wed, Sep 18, 11:45 PM
F2753190: D13381.diff
Wed, Sep 18, 5:00 PM
F2751664: D13381.id44300.diff
Wed, Sep 18, 3:05 PM
F2751625: D13381.id.diff
Wed, Sep 18, 3:05 PM
F2751608: D13381.diff
Wed, Sep 18, 3:04 PM
Subscribers
None

Details

Reviewers
ashoat
tomek
Summary

in order to set the farcaster avatar as thread avatar in 1 to 1 chats, we need to get the other user's FID from state.

not sure why we have so much code duplication here, but i'd like to defer addressing it.

Depends on D13380

Test Plan

thread avatars now look right when the other person in chat has set a farcaster avatar

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Wed, Sep 18, 6:24 AM
Harbormaster completed remote builds in B31690: Diff 44300.Wed, Sep 18, 6:41 AM
varun requested review of this revision.Wed, Sep 18, 6:41 AM
ashoat requested changes to this revision.Wed, Sep 18, 7:56 AM
ashoat added inline comments.
native/avatars/thread-avatar.react.js
46–47

I don't think we can rely on the FID here... I don't think it gets updated when it changes on identity.

Don't we need to go through UserIdentityCache?

This revision now requires changes to proceed.Wed, Sep 18, 7:56 AM

Revision Contents
Changeset List

PathSize
native/
avatars/
19 lines
web/
avatars/
19 lines

Diff 44300

View Options

native/avatars/thread-avatar.react.js

Loading...
View Options

web/avatars/thread-avatar.react.js

Loading...