Page MenuHomePhabricator
Differential D13381

[native][web] make farcaster avatars work as thread avatars
ClosedPublic
Actions

Authored by varun on Sep 18 2024, 6:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 4:46 PM
Unknown Object (File)
Fri, Mar 7, 5:10 PM
Unknown Object (File)
Fri, Feb 28, 9:38 AM
Unknown Object (File)
Fri, Feb 28, 9:37 AM
Unknown Object (File)
Feb 6 2025, 10:39 AM
Unknown Object (File)
Feb 6 2025, 5:23 AM
Unknown Object (File)
Jan 30 2025, 1:09 PM
Unknown Object (File)
Jan 30 2025, 1:08 PM
View All 51 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM0332be8a66e3: [native][web] make farcaster avatars work as thread avatars
Summary

in order to set the farcaster avatar as thread avatar in 1 to 1 chats, we need to get the other user's FID from state.

not sure why we have so much code duplication here, but i'd like to defer addressing it.

Depends on D13380

Test Plan

thread avatars now look right when the other person in chat has set a farcaster avatar

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 18 2024, 6:24 AM
Harbormaster completed remote builds in B31690: Diff 44300.Sep 18 2024, 6:41 AM
varun requested review of this revision.Sep 18 2024, 6:41 AM
ashoat requested changes to this revision.Sep 18 2024, 7:56 AM
ashoat added inline comments.
native/avatars/thread-avatar.react.js
46–47 ↗(On Diff #44300)

I don't think we can rely on the FID here... I don't think it gets updated when it changes on identity.

Don't we need to go through UserIdentityCache?

This revision now requires changes to proceed.Sep 18 2024, 7:56 AM
ashoat accepted this revision.Sep 19 2024, 3:37 PM
ashoat added inline comments.
native/avatars/thread-avatar.react.js
46–47 ↗(On Diff #44300)

Looked at this a bit more... handleUserStoreFIDs in FarcasterDataHandler makes sure auxUserStore is kept up-to-date based on UserIdentityCache, so I think this is safe

This revision is now accepted and ready to land.Sep 19 2024, 3:37 PM
varun added a child revision: D13456: [web] display farcaster avatar when it's set.Sep 24 2024, 3:25 PM
Closed by commit rCOMM0332be8a66e3: [native][web] make farcaster avatars work as thread avatars (authored by varun). · Explain WhySep 25 2024, 7:24 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM0332be8a66e3: [native][web] make farcaster avatars work as thread avatars.

Revision Contents
Changeset List

PathSize
native/
avatars/
19 lines
web/
avatars/
19 lines

Diff 44550

View Options

native/avatars/thread-avatar.react.js

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linesfunction getVideoProcessingPlan(input: Input): Plan {
} }
const outputFilename = replaceExtension( const outputFilename = replaceExtension(
`transcode.${uuid}.${sanitizedFilename}`, `transcode.${uuid}.${sanitizedFilename}`,
'mp4', 'mp4',
); );
const outputPath = `${outputDirectory}${outputFilename}`; const outputPath = `${outputDirectory}${outputFilename}`;
let quality, speed, scale; let hardwareAcceleration, quality, speed, scale, pixelFormat;
if (outputCodec === 'h264') { if (outputCodec === 'h264_mediacodec') {
const { floor, min, max, log2 } = Math; hardwareAcceleration = 'mediacodec';
const crf = floor(min(5, max(0, log2(inputDuration / 5)))) + 23; quality = '';
quality = `-crf ${crf}`; speed = '';
speed = '-preset ultrafast';
scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`; scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`;
pixelFormat = '';
} else if (outputCodec === 'h264_videotoolbox') { } else if (outputCodec === 'h264_videotoolbox') {
hardwareAcceleration = 'videotoolbox';
quality = '-profile:v baseline'; quality = '-profile:v baseline';
speed = '-realtime 1'; speed = '-realtime 1';
const { width, height } = inputDimensions; const { width, height } = inputDimensions;
scale = ''; scale = '';
const exceedsDimensions = width > maxWidth || height > maxHeight; const exceedsDimensions = width > maxWidth || height > maxHeight;
if (exceedsDimensions && width / height > maxWidth / maxHeight) { if (exceedsDimensions && width / height > maxWidth / maxHeight) {
scale = `-vf scale=${maxWidth}:-1`; scale = `-vf scale=${maxWidth}:-1`;
} else if (exceedsDimensions) { } else if (exceedsDimensions) {
scale = `-vf scale=-1:${maxHeight}`; scale = `-vf scale=-1:${maxHeight}`;
} }
pixelFormat = '-pix_fmt yuv420p';
} else { } else {
invariant(false, `unrecognized outputCodec ${outputCodec}`); invariant(false, `unrecognized outputCodec ${outputCodec}`);
} }
const ffmpegCommand = const ffmpegCommand =
`-hwaccel ${hardwareAcceleration} ` +
`-i ${inputPath} ` + `-i ${inputPath} ` +
`-c:a copy -c:v ${outputCodec} ` + `-c:a copy -c:v ${outputCodec} ` +
`${quality} ` + `${quality} ` +
'-vsync 2 -r 30 ' + '-fps_mode cfr -r 30 ' +
`${scale} ` + `${scale} ` +
`${speed} ` + `${speed} ` +
'-movflags +faststart ' + '-movflags +faststart ' +
'-pix_fmt yuv420p ' + `${pixelFormat} ` +
'-v quiet ' + '-v quiet ' +
outputPath; outputPath;
return { action: 'process', thumbnailPath, outputPath, ffmpegCommand }; return { action: 'process', thumbnailPath, outputPath, ffmpegCommand };
} }
function getHasMultipleFramesProbeCommand(path: string): string { function getHasMultipleFramesProbeCommand(path: string): string {
const ffprobeCommand = const ffprobeCommand =
Show All 17 Lines
View Options

web/avatars/thread-avatar.react.js

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linesfunction getVideoProcessingPlan(input: Input): Plan {
} }
const outputFilename = replaceExtension( const outputFilename = replaceExtension(
`transcode.${uuid}.${sanitizedFilename}`, `transcode.${uuid}.${sanitizedFilename}`,
'mp4', 'mp4',
); );
const outputPath = `${outputDirectory}${outputFilename}`; const outputPath = `${outputDirectory}${outputFilename}`;
let quality, speed, scale; let hardwareAcceleration, quality, speed, scale, pixelFormat;
if (outputCodec === 'h264') { if (outputCodec === 'h264_mediacodec') {
const { floor, min, max, log2 } = Math; hardwareAcceleration = 'mediacodec';
const crf = floor(min(5, max(0, log2(inputDuration / 5)))) + 23; quality = '';
quality = `-crf ${crf}`; speed = '';
speed = '-preset ultrafast';
scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`; scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`;
pixelFormat = '';
} else if (outputCodec === 'h264_videotoolbox') { } else if (outputCodec === 'h264_videotoolbox') {
hardwareAcceleration = 'videotoolbox';
quality = '-profile:v baseline'; quality = '-profile:v baseline';
speed = '-realtime 1'; speed = '-realtime 1';
const { width, height } = inputDimensions; const { width, height } = inputDimensions;
scale = ''; scale = '';
const exceedsDimensions = width > maxWidth || height > maxHeight; const exceedsDimensions = width > maxWidth || height > maxHeight;
if (exceedsDimensions && width / height > maxWidth / maxHeight) { if (exceedsDimensions && width / height > maxWidth / maxHeight) {
scale = `-vf scale=${maxWidth}:-1`; scale = `-vf scale=${maxWidth}:-1`;
} else if (exceedsDimensions) { } else if (exceedsDimensions) {
scale = `-vf scale=-1:${maxHeight}`; scale = `-vf scale=-1:${maxHeight}`;
} }
pixelFormat = '-pix_fmt yuv420p';
} else { } else {
invariant(false, `unrecognized outputCodec ${outputCodec}`); invariant(false, `unrecognized outputCodec ${outputCodec}`);
} }
const ffmpegCommand = const ffmpegCommand =
`-hwaccel ${hardwareAcceleration} ` +
`-i ${inputPath} ` + `-i ${inputPath} ` +
`-c:a copy -c:v ${outputCodec} ` + `-c:a copy -c:v ${outputCodec} ` +
`${quality} ` + `${quality} ` +
'-vsync 2 -r 30 ' + '-fps_mode cfr -r 30 ' +
`${scale} ` + `${scale} ` +
`${speed} ` + `${speed} ` +
'-movflags +faststart ' + '-movflags +faststart ' +
'-pix_fmt yuv420p ' + `${pixelFormat} ` +
'-v quiet ' + '-v quiet ' +
outputPath; outputPath;
return { action: 'process', thumbnailPath, outputPath, ffmpegCommand }; return { action: 'process', thumbnailPath, outputPath, ffmpegCommand };
} }
function getHasMultipleFramesProbeCommand(path: string): string { function getHasMultipleFramesProbeCommand(path: string): string {
const ffprobeCommand = const ffprobeCommand =
Show All 17 Lines