[native][web] make farcaster avatars work as thread avatars
ClosedPublic
Actions

Authored by varun on Sep 18 2024, 6:24 AM.

Details

Reviewers

ashoat
tomek

Commits

Summary

in order to set the farcaster avatar as thread avatar in 1 to 1 chats, we need to get the other user's FID from state.

not sure why we have so much code duplication here, but i'd like to defer addressing it.

Depends on D13380

Test Plan

thread avatars now look right when the other person in chat has set a farcaster avatar

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

varun requested review of this revision.Sep 18 2024, 6:41 AM

ashoat requested changes to this revision.Sep 18 2024, 7:56 AM

ashoat added inline comments.

native/avatars/thread-avatar.react.js
46–47	I don't think we can rely on the FID here... I don't think it gets updated when it changes on identity. Don't we need to go through `UserIdentityCache`?

This revision now requires changes to proceed.Sep 18 2024, 7:56 AM

ashoat added inline comments.

native/avatars/thread-avatar.react.js
46–47	Looked at this a bit more... `handleUserStoreFIDs` in `FarcasterDataHandler` makes sure `auxUserStore` is kept up-to-date based on `UserIdentityCache`, so I think this is safe