Page MenuHomePhabricator
Differential D13456

[web] display farcaster avatar when it's set
ClosedPublic
Actions

Authored by varun on Sep 24 2024, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:34 PM
Unknown Object (File)
Wed, Dec 18, 5:34 PM
Unknown Object (File)
Wed, Dec 18, 5:31 PM
Unknown Object (File)
Wed, Dec 18, 4:41 PM
Unknown Object (File)
Nov 10 2024, 2:41 AM
Unknown Object (File)
Nov 8 2024, 7:03 PM
Unknown Object (File)
Nov 8 2024, 7:01 PM
Unknown Object (File)
Oct 31 2024, 2:18 AM
View All 31 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set
Summary

in D13380 I made it possible to set a farcaster avatar from web. however after refactoring D13101, we won't actually display this avatar from the settings page when it's set without the changes in this diff

Depends on D13381

Test Plan

tested by setting and unsetting all avatar types from settings page on web

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 24 2024, 3:25 PM
Harbormaster completed remote builds in B31834: Diff 44520.Sep 24 2024, 3:42 PM
varun requested review of this revision.Sep 24 2024, 3:42 PM
ashoat accepted this revision.Sep 24 2024, 5:39 PM

Unclear why D13101 did this for native and not for web. That diff could've probably been broken up more

This revision is now accepted and ready to land.Sep 24 2024, 5:39 PM
Closed by commit rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set (authored by varun). · Explain WhySep 25 2024, 7:24 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMfaee4b8008e0: [web] display farcaster avatar when it's set.

Revision Contents
Changeset List

PathSize
web/
avatars/
27 lines

Diff 44551

View Options

web/avatars/user-avatar.react.js

Loading...