[native] get farcaster avatar selection working from profile
AbandonedPublic
Actions

Authored by varun on Aug 15 2024, 10:54 PM.

Details

Reviewers

ashoat
tomek

Summary

Depends on D13101

Test Plan

successfully changed avatar to a farcaster avatar from profile screen. was able to reset to default after.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 15 2024, 10:54 PM

varun held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 10:54 PM

Harbormaster completed remote builds in B31126: Diff 43423.Aug 15 2024, 11:39 PM

varun published this revision for review.Aug 19 2024, 7:23 AM

varun edited the summary of this revision. (Show Details)

varun edited the test plan for this revision. (Show Details)

varun added a parent revision: D13101: [native] let user choose farcaster avatar.

varun added reviewers: ashoat, tomek.Aug 19 2024, 7:37 AM

I don't understand this diff and what it's doing... I suspect that it has to do with one of the preceding diffs that are still in draft state.

Can you:

Re-request review once the whole stack is ready
Add a diff description

lib/hooks/fc-cache.js
162 ↗	(On Diff #43423)	Looks like a change that should be in another diff, but the other diff appears to be in draft form still?

This revision now requires changes to proceed.Aug 20 2024, 12:42 PM

varun added a child revision: D13377: [lib] update updateUserAvatarRequestValidator.Sep 18 2024, 6:10 AM

rebase

varun abandoned this revision.Sep 18 2024, 7:19 AM

Harbormaster completed remote builds in B31698: Diff 44311.Sep 18 2024, 7:38 AM

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

avatar-selection.react.js

3 lines

avatars/

edit-user-avatar.react.js

1 line

Diff 44311

View Options

native/account/registration/avatar-selection.react.js