Page MenuHomePhabricator
Differential D13102

[native] get farcaster avatar selection working from profile
Needs RevisionPublic
Actions

Authored by varun on Aug 15 2024, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 4:21 PM
Unknown Object (File)
Fri, Sep 6, 1:13 PM
Unknown Object (File)
Wed, Sep 4, 8:43 AM
Unknown Object (File)
Sun, Sep 1, 3:52 AM
Unknown Object (File)
Thu, Aug 29, 12:26 PM
Unknown Object (File)
Thu, Aug 29, 8:17 AM
Unknown Object (File)
Tue, Aug 27, 12:42 PM
Unknown Object (File)
Tue, Aug 27, 8:03 AM
View All 22 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
tomek
Summary

Depends on D13101

Test Plan

successfully changed avatar to a farcaster avatar from profile screen. was able to reset to default after.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Aug 15 2024, 10:54 PM
varun held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 10:54 PM
Harbormaster completed remote builds in B31126: Diff 43423.Aug 15 2024, 11:39 PM
varun published this revision for review.Mon, Aug 19, 7:23 AM
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)
varun added a parent revision: D13101: [native] let user choose farcaster avatar during registration.
varun added reviewers: ashoat, tomek.Mon, Aug 19, 7:37 AM
ashoat requested changes to this revision.Tue, Aug 20, 12:42 PM

I don't understand this diff and what it's doing... I suspect that it has to do with one of the preceding diffs that are still in draft state.

Can you:

  1. Re-request review once the whole stack is ready
  2. Add a diff description
lib/hooks/fc-cache.js
162

Looks like a change that should be in another diff, but the other diff appears to be in draft form still?

This revision now requires changes to proceed.Tue, Aug 20, 12:42 PM

Revision Contents
Changeset List

PathSize
lib/
hooks/
3 lines
native/
account/
registration/
3 lines
avatars/
5 lines

Diff 43423

View Options

lib/hooks/fc-cache.js

Loading...
View Options

native/account/registration/avatar-selection.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...