When we last talked about this work, we were considering two options on how to proceed. It looks like you've taken the second approach – can you explain a bit about how you derisked this part?

To do this, we'd need to form a native media selection which might involve first saving the file to the file system

Curious if you've tested on both iOS and Android. Requesting changes to get an answer to the above (although might be best to document on Linear?)

native/account/registration/connect-farcaster.react.js
136	What's the significance of `pfpURL`? `getFCAvatarURLs` appears to be introduced in the prior diff, but it's still in draft form
150	Why do we use `null` here but `undefined` in `setCachedSelections` below?

This revision now requires changes to proceed.Tue, Aug 20, 12:40 PM

varun added inline comments.Fri, Sep 6, 12:49 PM

native/account/registration/connect-farcaster.react.js
136	`pfpURL` is the URL to the farcaster avatar provided by neynar
150	i used `undefined` below because i had typed `farcasterAvatarURL` as `+farcasterAvatarURL?: string,` in `CachedUserSelections` (further below in diff). i can't think of a good reason to not change it to `?string` and use `null` below, so will fix

In D13100#370563, @ashoat wrote:

When we last talked about this work, we were considering two options on how to proceed. It looks like you've taken the second approach – can you explain a bit about how you derisked this part?

To do this, we'd need to form a native media selection which might involve first saving the file to the file system

Curious if you've tested on both iOS and Android. Requesting changes to get an answer to the above (although might be best to document on Linear?)

https://linear.app/comm/issue/ENG-9182/allow-users-to-set-farcaster-avatar-on-native we can discuss further here. i've opted for option 1

ashoat added inline comments.Mon, Sep 9, 12:35 PM

native/account/registration/connect-farcaster.react.js
136	What's the significance of this parameter to `getFCAvatarURLs`? Why is it `null` here? When should it be `null` and when shouldn't it be?

In D13100#373832, @varun wrote:

In D13100#370563, @ashoat wrote:

When we last talked about this work, we were considering two options on how to proceed. It looks like you've taken the second approach – can you explain a bit about how you derisked this part?

To do this, we'd need to form a native media selection which might involve first saving the file to the file system

Curious if you've tested on both iOS and Android. Requesting changes to get an answer to the above (although might be best to document on Linear?)

https://linear.app/comm/issue/ENG-9182/allow-users-to-set-farcaster-avatar-on-native we can discuss further here. i've opted for option 1

Okay, sure. When you've finished responding to my last review (whether on Linear or here), feel free to re-request review. Make sure you respond to all parts