we can fetch the farcaster avatar URL once the user has connected a farcaster account and then pass it through the registration wizard so that it's available on the avatar selection screen
Depends on D13099
Differential D13100
[native] add farcaster avatar URL to registration workflow varun on Aug 15 2024, 10:53 PM. Authored by Tags None Referenced Files
Details we can fetch the farcaster avatar URL once the user has connected a farcaster account and then pass it through the registration wizard so that it's available on the avatar selection screen Depends on D13099 tested later in stack by successfully setting avatar from farcaster
Diff Detail
Event TimelineComment Actions When we last talked about this work, we were considering two options on how to proceed. It looks like you've taken the second approach – can you explain a bit about how you derisked this part?
Curious if you've tested on both iOS and Android. Requesting changes to get an answer to the above (although might be best to document on Linear?)
Comment Actions https://linear.app/comm/issue/ENG-9182/allow-users-to-set-farcaster-avatar-on-native we can discuss further here. i've opted for option 1
Comment Actions Okay, sure. When you've finished responding to my last review (whether on Linear or here), feel free to re-request review. Make sure you respond to all parts
Comment Actions Explanation for pfpURL: null doesn't make sense to me. Can you remove it, or explain exactly why you need it? It feels strange to be passing in pfpURL to a function that returns it, and it feels double strange to be setting it to null.
|