Page MenuHomePhabricator

[web] make it possible to select farcaster avatar on web
ClosedPublic

Authored by varun on Sep 18 2024, 6:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 7:03 AM
Unknown Object (File)
Wed, Nov 20, 7:03 AM
Unknown Object (File)
Wed, Nov 20, 7:03 AM
Unknown Object (File)
Wed, Nov 20, 6:39 AM
Unknown Object (File)
Oct 19 2024, 2:33 PM
Unknown Object (File)
Oct 19 2024, 2:33 PM
Unknown Object (File)
Oct 19 2024, 2:32 PM
Unknown Object (File)
Oct 19 2024, 2:31 PM
Subscribers
None

Details

Summary

if the user has an fid, we try to get their farcaster avatar URL. if we find a URL, we'll display the option to set the farcaster avatar as the user's comm avatar. if the user selects the farcaster avatar, their avatar is updated in the app and on the keyserver.

Depends on D13379

Test Plan

can successfully set farcaster avatar on web and it subsequently appears on other clients. can reset the avatar, too.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Sep 18 2024, 6:35 AM
ashoat added inline comments.
web/avatars/edit-user-avatar-menu.react.js
157 ↗(On Diff #44299)

Assume this will not be set if there is no FID?

This revision is now accepted and ready to land.Sep 18 2024, 7:55 AM
web/avatars/edit-user-avatar-menu.react.js
157 ↗(On Diff #44299)

yeah that's right, useFarcasterAvatar (renaming to useFarcasterAvatarURL before landing) will return null if there is no FID