[web] make it possible to select farcaster avatar on web
ClosedPublic
Actions

Authored by varun on Sep 18 2024, 6:19 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM992b6e95adc2: [web] make it possible to select farcaster avatar on web

Summary

if the user has an fid, we try to get their farcaster avatar URL. if we find a URL, we'll display the option to set the farcaster avatar as the user's comm avatar. if the user selects the farcaster avatar, their avatar is updated in the app and on the keyserver.

Depends on D13379

Test Plan

can successfully set farcaster avatar on web and it subsequently appears on other clients. can reset the avatar, too.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Sep 18 2024, 6:19 AM

varun added a child revision: D13381: [native][web] make farcaster avatars work as thread avatars.Sep 18 2024, 6:24 AM

Harbormaster completed remote builds in B31689: Diff 44299.Sep 18 2024, 6:35 AM

varun requested review of this revision.Sep 18 2024, 6:35 AM

ashoat accepted this revision.Sep 18 2024, 7:55 AM

ashoat added inline comments.

web/avatars/edit-user-avatar-menu.react.js
157 ↗	(On Diff #44299)	Assume this will not be set if there is no FID?

This revision is now accepted and ready to land.Sep 18 2024, 7:55 AM

varun mentioned this in D13456: [web] display farcaster avatar when it's set.Tue, Sep 24, 3:25 PM

varun added inline comments.Wed, Sep 25, 7:05 AM

web/avatars/edit-user-avatar-menu.react.js
157 ↗	(On Diff #44299)	yeah that's right, `useFarcasterAvatar` (renaming to `useFarcasterAvatarURL` before landing) will return null if there is no FID