[lib] update getAvatarForUser signature
ClosedPublic
Actions

Authored by varun on Tue, Sep 24, 8:49 AM.

Details

Reviewers

Commits

rCOMM9dc74fdfbfc6: [lib] update getAvatarForUser signature

Summary

getAvatarForUser just needs a type that contains optional, nullable username and avatar fields. modifying the function signature to make it clear what data we're dealing with here.

Test Plan

tested with rest of stack by successfully setting thread and user avatars

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Tue, Sep 24, 8:49 AM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Sep 24, 8:49 AM

will add this to existing diff stack

Harbormaster completed remote builds in B31818: Diff 44486.Tue, Sep 24, 9:13 AM

rebase and publish for review

varun added a parent revision: D13100: [native] add farcaster avatar URL to registration workflow.Tue, Sep 24, 2:45 PM

varun added a child revision: D13101: [native] let user choose farcaster avatar.

Harbormaster completed remote builds in B31830: Diff 44502.Tue, Sep 24, 3:01 PM

ashoat accepted this revision.Tue, Sep 24, 4:02 PM

This revision is now accepted and ready to land.Tue, Sep 24, 4:02 PM

Closed by commit rCOMM9dc74fdfbfc6: [lib] update getAvatarForUser signature (authored by varun). · Explain WhyWed, Sep 25, 7:24 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9dc74fdfbfc6: [lib] update getAvatarForUser signature.

Revision Contents
Changeset List

Path

Size

lib/

shared/

avatar-utils.js

12 lines

Diff 44544

View Options

lib/shared/avatar-utils.js

[lib] update getAvatarForUser signatureClosedPublicActions