Paths

Table of Contentst

Differential D13099

[lib] add getFCAvatarURLs method to NeynarClientProvider
ClosedPublic
Actions

Authored by varun on Aug 15 2024, 10:53 PM.

Tags

None

Referenced Files

	F3197255: D13099.diff
	Sat, Nov 9, 7:51 AM

	F3188620: D13099.id44448.diff
	Fri, Nov 8, 7:02 PM

	F3188619: D13099.id43420.diff
	Fri, Nov 8, 7:02 PM

	F3188618: D13099.id44500.diff
	Fri, Nov 8, 7:02 PM

	F3188617: D13099.id44446.diff
	Fri, Nov 8, 7:02 PM

	F3188609: D13099.diff
	Fri, Nov 8, 7:02 PM

	Unknown Object (File)
	Fri, Nov 8, 2:08 AM

	Unknown Object (File)
	Wed, Oct 30, 11:24 PM

View All 56 Files

Subscribers

Details

Reviewers

ashoat
tomek

Commits

rCOMM360954426fa1: [lib] add getFCAvatarURLs method to NeynarClientProvider

Summary

Based this off the existing client provider method for FC usernames

Deduping made this code harder to follow. That said, I can revise this if reviewers think it would be better anyway

Depends on D13098

Test Plan

tested at end of stack by successfully fetching farcaster avatar URL with neynar

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 15 2024, 10:53 PM

varun held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 10:53 PM

varun added a child revision: D13100: [native] add farcaster avatar URL to registration workflow.Aug 15 2024, 10:53 PM

Harbormaster completed remote builds in B31123: Diff 43420.Aug 15 2024, 11:16 PM

rebase

varun edited the summary of this revision. (Show Details)Sep 6 2024, 12:59 PM

varun edited the test plan for this revision. (Show Details)

varun edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B31469: Diff 43947.Sep 6 2024, 1:19 PM

varun published this revision for review.Sep 18 2024, 6:43 AM

varun added reviewers: ashoat, tomek.

rebase

Harbormaster completed remote builds in B31694: Diff 44306.Sep 18 2024, 7:29 AM

ashoat accepted this revision.Sep 18 2024, 9:10 AM

This revision is now accepted and ready to land.Sep 18 2024, 9:10 AM

ashoat mentioned this in D13100: [native] add farcaster avatar URL to registration workflow.Sep 18 2024, 11:48 AM

use new base type for farcaster avatar URLs

varun planned changes to this revision.Sep 23 2024, 10:55 AM

varun added inline comments.

lib/utils/farcaster-helpers.js
125–127 ↗	(On Diff #44446)	realized this can probably be removed

Harbormaster completed remote builds in B31784: Diff 44446.Sep 23 2024, 11:05 AM

remove unnecessary condition

This revision is now accepted and ready to land.Sep 23 2024, 11:17 AM

i don't want this reviewed until i've finalized the whole stack

Harbormaster completed remote builds in B31786: Diff 44448.Sep 23 2024, 11:35 AM

rebase and publish for review

This revision is now accepted and ready to land.Sep 24 2024, 2:44 PM

sorry to request review again, but this changed considerably after addressing feedback later in stack

Harbormaster completed remote builds in B31828: Diff 44500.Sep 24 2024, 3:01 PM

ashoat accepted this revision.Sep 24 2024, 4:00 PM

ashoat added inline comments.

lib/utils/farcaster-helpers.js
5–20 ↗	(On Diff #44500)	Nit: I would change how these are grouped – group `BaseFCNamesInfo` / `GetFCNames`, and `BaseFCAvatarInfo` / `GetFCAvatarURLs` Meanwhile the avatar stuff can be moved to above the definition of `getFCAvatarURLs`

This revision is now accepted and ready to land.Sep 24 2024, 4:00 PM

Closed by commit rCOMM360954426fa1: [lib] add getFCAvatarURLs method to NeynarClientProvider (authored by varun). · Explain WhySep 25 2024, 7:23 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM360954426fa1: [lib] add getFCAvatarURLs method to NeynarClientProvider.

Revision Contents
Changeset List

Path

Size

lib/

components/

neynar-client-provider.react.js

7 lines

utils/

farcaster-helpers.js

71 lines

Diff 43947

lib/components/neynar-client-provider.react.js

Loading...

lib/utils/farcaster-helpers.js

Loading...