Depends on D13097
Details
Details
tested later in stack by successfully setting avatar from farcaster
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/utils/fc-cache.js | ||
|---|---|---|
| 144 ↗ | (On Diff #43419) | wasn't sure about this line |
| lib/utils/fc-cache.js | ||
|---|---|---|
| 144 ↗ | (On Diff #43419) | JavaScript is weird... this condition will let null through because typeof null === 'object' To be fully consistent with the prior implementation, you should add || farcasterUser === null here (although not clear how important that is) |
| lib/utils/fc-cache.js | ||
|---|---|---|
| 144 ↗ | (On Diff #43419) | Actually I'd just add || !farcasterUser rather than || farcasterUser === null |