Page MenuHomePhabricator
Differential D13202

[web] Keep an ID of a thick thread in the URL
ClosedPublic
Actions

Authored by tomek on Aug 28 2024, 9:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 21 2025, 5:48 AM
Unknown Object (File)
Jan 15 2025, 7:38 AM
Unknown Object (File)
Dec 18 2024, 1:31 PM
Unknown Object (File)
Dec 18 2024, 1:31 PM
Unknown Object (File)
Dec 18 2024, 1:31 PM
Unknown Object (File)
Dec 18 2024, 1:31 PM
Unknown Object (File)
Nov 30 2024, 4:04 PM
Unknown Object (File)
Nov 24 2024, 9:30 AM
View All 44 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMaa4e52cc0468: [web] Keep an ID of a thick thread in the URL
Summary

When a user opens a URL to a thick thread, we shouldn't inform the keyserver about it and ignore the id it sends us.

https://linear.app/comm/issue/ENG-9099/opening-a-link-to-a-thick-thread-resets-the-navigation-on-web

Test Plan

Refresh a web page where a thick thread is open and make sure the URL doesn't change.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
utils/
2 lines
web/
redux/
6 lines
9 lines

Diff 43774

View Options

lib/utils/validation-utils.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/redux/action-types.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

web/redux/initial-state-gate.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents