- Prettier does not run on flow-typed to avoid applying changes to libdefs that come from upstream. As such, it's important that we manually fix up whitespace issues.
- In libdefs, we should always be specific between {| |} and { ... }, and never just use {}
- We should prefer type to interface whenever possible to avoid complex inheritance-based typing
- We should maintain consistent style across the file. This diff replaces the inconsistent ; that was introduced in D13175 with , that matches the rest of the file
- We should always makes types read-only unless they need to be written to
Details
Details
- Reviewers
inka tomek - Commits
- rCOMM5e6732ede2db: [native] Fix up issues from D13175
Flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thank you for fixing this. I copied ts types and was changing them step by step, and clearly missed those things