Page MenuHomePhabricator

[native] Fix up issues from D13175
ClosedPublic

Authored by ashoat on Fri, Sep 6, 12:06 PM.
Tags
None
Referenced Files
F2766745: D13263.diff
Thu, Sep 19, 3:46 PM
Unknown Object (File)
Wed, Sep 18, 1:26 PM
Unknown Object (File)
Wed, Sep 18, 4:38 AM
Unknown Object (File)
Wed, Sep 18, 1:00 AM
Unknown Object (File)
Tue, Sep 17, 7:24 PM
Unknown Object (File)
Mon, Sep 16, 8:39 PM
Unknown Object (File)
Mon, Sep 16, 7:20 AM
Unknown Object (File)
Sun, Sep 15, 10:14 PM
Subscribers
None

Details

Summary
  1. Prettier does not run on flow-typed to avoid applying changes to libdefs that come from upstream. As such, it's important that we manually fix up whitespace issues.
  2. In libdefs, we should always be specific between {| |} and { ... }, and never just use {}
  3. We should prefer type to interface whenever possible to avoid complex inheritance-based typing
  4. We should maintain consistent style across the file. This diff replaces the inconsistent ; that was introduced in D13175 with , that matches the rest of the file
  5. We should always makes types read-only unless they need to be written to
Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Setting both @inka and @tomek as blocking to make sure they both understand the issues in D13175. Please make sure you both read the diff description carefully, and avoid making/approving diffs with these issues going forward

Thank you for fixing this. I copied ts types and was changing them step by step, and clearly missed those things

This revision is now accepted and ready to land.Mon, Sep 9, 5:04 AM
This revision was automatically updated to reflect the committed changes.