Page MenuHomePhabricator
Differential D13270

[lib] Add more keys to redacted values
ClosedPublic
Actions

Authored by bartek on Mon, Sep 9, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 17, 12:14 PM
Unknown Object (File)
Tue, Sep 17, 9:45 AM
Unknown Object (File)
Mon, Sep 16, 7:27 PM
Unknown Object (File)
Mon, Sep 16, 8:14 AM
Unknown Object (File)
Mon, Sep 16, 3:12 AM
Unknown Object (File)
Sun, Sep 15, 12:32 PM
Unknown Object (File)
Sun, Sep 15, 11:32 AM
Unknown Object (File)
Sun, Sep 15, 3:33 AM
View All 15 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM5622ed8fcc83: [lib] Add more keys to redacted values
Summary

Address ENG-8717.

  • Added more keys to the redacted lists: CSAT, device lists, encrypted blob data
  • For Blob URIs, created a separate placeholder value
Test Plan

Triggered crash report on my test account. Verified that some Redux values (like commServicesAccessToken) are now redacted.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Sep 9, 6:09 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptMon, Sep 9, 6:09 AM
Harbormaster completed remote builds in B31494: Diff 43980.Mon, Sep 9, 6:38 AM
bartek published this revision for review.Mon, Sep 9, 6:40 AM
ashoat accepted this revision.Mon, Sep 9, 1:40 PM

Thanks for doing this!

This revision is now accepted and ready to land.Mon, Sep 9, 1:40 PM
Closed by commit rCOMM5622ed8fcc83: [lib] Add more keys to redacted values (authored by bartek). · Explain WhyWed, Sep 11, 12:53 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM5622ed8fcc83: [lib] Add more keys to redacted values.

Revision Contents
Changeset List

PathSize
lib/
utils/
18 lines

Diff 44021

View Options

lib/utils/sanitization.js

Loading...