Page MenuHomePhabricator

[lib] Add more keys to redacted values
ClosedPublic

Authored by bartek on Sep 9 2024, 6:09 AM.
Tags
None
Referenced Files
F3347423: D13270.diff
Fri, Nov 22, 12:12 PM
Unknown Object (File)
Thu, Nov 14, 1:02 PM
Unknown Object (File)
Thu, Nov 14, 12:59 PM
Unknown Object (File)
Sun, Nov 10, 10:24 PM
Unknown Object (File)
Sun, Nov 10, 6:54 PM
Unknown Object (File)
Sun, Nov 10, 8:01 AM
Unknown Object (File)
Thu, Nov 7, 1:36 PM
Unknown Object (File)
Oct 22 2024, 10:45 AM
Subscribers

Details

Summary

Address ENG-8717.

  • Added more keys to the redacted lists: CSAT, device lists, encrypted blob data
  • For Blob URIs, created a separate placeholder value
Test Plan

Triggered crash report on my test account. Verified that some Redux values (like commServicesAccessToken) are now redacted.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 9 2024, 6:40 AM

Thanks for doing this!

This revision is now accepted and ready to land.Sep 9 2024, 1:40 PM
This revision was automatically updated to reflect the committed changes.