Page MenuHomePhabricator

[keyserver] convert secondary migration block from do while to regular while loop
ClosedPublic

Authored by will on Sep 9 2024, 12:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:49 AM
Unknown Object (File)
Sat, Nov 9, 6:28 PM
Unknown Object (File)
Sat, Nov 9, 8:11 AM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Tue, Oct 22, 5:34 AM
Unknown Object (File)
Tue, Oct 22, 5:33 AM
Unknown Object (File)
Mon, Oct 21, 8:54 AM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Subscribers

Details

Summary

The do-while ensures an unnecessary 5 second sleep time. Converting this to a while loop ensures this only happens if necessary

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Sep 9 2024, 1:04 PM
ashoat requested changes to this revision.Sep 9 2024, 1:38 PM

Good point here – can we avoid the sleep unless we need it? I think my feedback here was misguided... we should probably just revert to the version of the code you had before that feedback

This revision now requires changes to proceed.Sep 9 2024, 1:38 PM
will retitled this revision from [keyserver] flip sleep and db version check to [keyserver] convert secondary migration block from do while to regular while loop.Sep 11 2024, 12:48 PM
will edited the summary of this revision. (Show Details)

Thanks, and sorry for my confusion!

This revision is now accepted and ready to land.Sep 11 2024, 1:07 PM