Page MenuHomePhabricator

[keyserver] convert secondary migration block from do while to regular while loop
ClosedPublic

Authored by will on Sep 9 2024, 12:47 PM.
Tags
None
Referenced Files
F3197347: D13273.diff
Sat, Nov 9, 8:11 AM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Tue, Oct 22, 5:34 AM
Unknown Object (File)
Tue, Oct 22, 5:33 AM
Unknown Object (File)
Mon, Oct 21, 8:54 AM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Unknown Object (File)
Sun, Oct 13, 9:50 PM
Unknown Object (File)
Sat, Oct 12, 1:48 AM
Subscribers

Details

Summary

The do-while ensures an unnecessary 5 second sleep time. Converting this to a while loop ensures this only happens if necessary

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Branch
flip_sleep_version_check
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will requested review of this revision.Sep 9 2024, 1:04 PM
ashoat requested changes to this revision.Sep 9 2024, 1:38 PM

Good point here – can we avoid the sleep unless we need it? I think my feedback here was misguided... we should probably just revert to the version of the code you had before that feedback

This revision now requires changes to proceed.Sep 9 2024, 1:38 PM
will retitled this revision from [keyserver] flip sleep and db version check to [keyserver] convert secondary migration block from do while to regular while loop.Sep 11 2024, 12:48 PM
will edited the summary of this revision. (Show Details)

Thanks, and sorry for my confusion!

This revision is now accepted and ready to land.Sep 11 2024, 1:07 PM