Page MenuHomePhabricator

[identity] don't check reserved_usernames.json when registering existing users from keyserver
ClosedPublic

Authored by varun on Sep 10 2024, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 15, 6:17 AM
Unknown Object (File)
Wed, Jan 15, 6:15 AM
Unknown Object (File)
Fri, Dec 27, 1:41 AM
Unknown Object (File)
Fri, Dec 27, 1:41 AM
Unknown Object (File)
Fri, Dec 27, 1:39 AM
Unknown Object (File)
Dec 16 2024, 5:10 AM
Unknown Object (File)
Dec 2 2024, 4:34 AM
Unknown Object (File)
Nov 26 2024, 7:56 PM
Subscribers

Details

Summary

https://linear.app/comm/issue/ENG-9247/register-reserved-password-user-start-rejects-already-registered

If a username is already registered with ashoat's keyserver, there's no need to check if it's in reserved_usernames.json. We should just allow the username to be registered on the identity service via the reserved registration workflow.

Test Plan
  • Registered username book with my keyserver by setting usingCSAT to false and modifying the reserved usernames js file. Keyserver added username to reserved usernames table on staging identity.
  • Flipped usingCSAT to true, was registered with staging identity

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable