Differential D13295

[lib] fetchLedFarcasterChannels method
ClosedPublic
Actions

Authored by varun on Sep 11 2024, 10:58 AM.

Details

Reviewers

ashoat

Commits

rCOMM0773972d40c7: [lib] fetchLedFarcasterChannels method

Summary

similar to fetchFollowedFarcasterChannels, except we filter out channels that the user does not lead

Depends on D13293

Test Plan

https://gist.github.com/vdhanan/fdc48cf3a29f0394ec5646f7c728cefa

confirmed that the new method returned all the channels led by that user and that the existing method returned the same results as before

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Sep 11 2024, 10:58 AM

Herald added a subscriber: tomek. · View Herald TranscriptSep 11 2024, 10:58 AM

varun edited the test plan for this revision. (Show Details)Sep 11 2024, 10:59 AM

varun edited the test plan for this revision. (Show Details)

remove unnecessary async keyword

Harbormaster completed remote builds in B31541: Diff 44050.Sep 11 2024, 11:16 AM

Harbormaster completed remote builds in B31545: Diff 44054.Sep 11 2024, 11:28 AM

varun requested review of this revision.Sep 11 2024, 11:28 AM

Guessing there isn't a better Neynar API for this?

This revision is now accepted and ready to land.Sep 11 2024, 12:56 PM

In D13295#374730, @ashoat wrote:

Guessing there isn't a better Neynar API for this?

couldn't find a better one

varun added a child revision: D13300: [keyserver] update joinThread to automatically make farcaster channel lead a community admin.Sep 11 2024, 4:23 PM

varun removed a child revision: D13300: [keyserver] update joinThread to automatically make farcaster channel lead a community admin.Sep 11 2024, 4:33 PM

Closed by commit rCOMM0773972d40c7: [lib] fetchLedFarcasterChannels method (authored by varun). · Explain WhySep 11 2024, 4:38 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM0773972d40c7: [lib] fetchLedFarcasterChannels method.

varun added a child revision: D13300: [keyserver] update joinThread to automatically make farcaster channel lead a community admin.Sep 12 2024, 4:14 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

farcaster-types.js

4 lines

utils/

neynar-client.js

7 lines

Diff 44066

View Options

lib/types/farcaster-types.js