This addresses ENG-9255, and makes it so if a user identity fetch times out, the next time it's requested, we don't return null from the cache, but instead retry the fetch.
Details
Details
I set queryTimeout to 1 second, which made it time out. I confirmed in the logs that after the timeout, a second request was dispatched
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/components/user-identity-cache.react.js | ||
|---|---|---|
| 177 ↗ | (On Diff #44062) | This change was necessary to differentiate a failed fetch from a timeout |
| 205 ↗ | (On Diff #44062) | The above change makes sure that we use failedQueryCacheTimeout in the case of a successful fetch that simply returns no information for a given UID. In that case, we consider the request successful, and the identity to not exist |