Paths

Table of Contentst

Differential D13338

[web] Fix broken pending threads
ClosedPublic
Actions

Authored by tomek on Sep 13 2024, 10:03 AM.

Tags

None

Referenced Files

	F3345482: D13338.diff
	Fri, Nov 22, 6:13 AM

	Unknown Object (File)
	Wed, Nov 20, 7:01 AM

	Unknown Object (File)
	Wed, Nov 20, 6:40 AM

	Unknown Object (File)
	Sun, Nov 17, 1:08 PM

	Unknown Object (File)
	Sun, Nov 17, 1:05 PM

	Unknown Object (File)
	Thu, Nov 7, 10:17 PM

	Unknown Object (File)
	Thu, Nov 7, 4:50 PM

	Unknown Object (File)
	Wed, Oct 23, 9:12 AM

View All 39 Files

Subscribers

None

Details

Reviewers

kamil
bartek
ashoat

Commits

rCOMMc5f34caf9676: [web] Fix broken pending threads

Summary

In D13282 we modified the logic so that instead of an active thread ID we use active thread info that is taken from the thread store. Unfortunately, this change broke the pending threads which aren't present in the store. What we should do instead is to let the component provide the thread store for us.

https://linear.app/comm/issue/ENG-9268/pending-threads-are-broken-on-master-on-the-web

Test Plan

Check if it is possible to create a new thread by sending a text message in a pending thread.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Sep 13 2024, 10:03 AM

Harbormaster completed remote builds in B31618: Diff 44189.Sep 13 2024, 10:21 AM

tomek requested review of this revision.Sep 13 2024, 10:21 AM

bartek accepted this revision.Sep 13 2024, 10:33 AM

This revision is now accepted and ready to land.Sep 13 2024, 10:33 AM

bartek added inline comments.Sep 13 2024, 10:36 AM

web/chat/chat-input-bar.react.js
692 ↗	(On Diff #44189)	This probably can be narrowed down

ashoat accepted this revision.Sep 13 2024, 1:36 PM

ashoat added inline comments.

web/input/input-state-container.react.js
660–663 ↗	(On Diff #44189)	We can just pass in `this.cancelPendingUpload` directly if we define it as an arrow function

Feedback

Harbormaster completed remote builds in B31619: Diff 44190.Sep 13 2024, 1:57 PM

Closed by commit rCOMMc5f34caf9676: [web] Fix broken pending threads (authored by tomek, committed by ashoat). · Explain WhySep 13 2024, 2:01 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc5f34caf9676: [web] Fix broken pending threads.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-input-bar.react.js

14 lines

input/

input-state-container.react.js

47 lines

2 lines

Diff 44191

web/chat/chat-input-bar.react.js

Loading...

web/input/input-state-container.react.js

Loading...

web/input/input-state.js

Loading...