This differential prevents DM activity handler from spamming unread status unpdates by sending updates only for threads that are unread when we enter them and using debouncing when receiving messages to currently active thread.
Details
Details
- Add console log to each portion of sent dm's
- Ensure that when entering thick thread updates are sent once only if the thread was unread.
- Ensuure that after receiving stream of messages to thick thread, unread updates are sent only once 5 seconds after the last message.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-9267
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 89 | If there is pending debounced call from previous active thread we want to call it right now. | |
| 110 | Checking for change in latest message makes sense only if we are in the same thread. | |
| web/redux/redux-setup.js | ||
| 460 | This code was changing thick thread read status before dm activity handler could detect change and send necessary updates. | |
Comment Actions
This solution feels a lot more complicated than it should. Maybe it has to be that complicated, with canceling and flushing, but I'm not sure.
Would it be possible to have a memo, with activeThread as a dependency, where we store the denounced function and then simply call this function in an effect, without canceling and flushing?
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 53–67 ↗ | (On Diff #44345) | This can be made even more efficient, because updateDMActivity shouldn't require the whole thread info - it looks like the ID is the only thing that really matters there. |
| 126 ↗ | (On Diff #44345) | Can't we call updateActivityAfterLatestMessageChangeRef.current() here? |
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 126 ↗ | (On Diff #44345) | We can't since thread will be marked as read with 5 seconds delay after opening it. With current approach it happens immediately. |
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 126 ↗ | (On Diff #44345) | What do we do for thick threads? Is there no delay for them? |
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 126 ↗ | (On Diff #44345) | I don't understand this question. This component handles thick threads exclusively. It works like this: When unread thick thread is entered unread updates are sent immediately and so does happen UI change. When thick thread is opened and new messages are incoming very shortly one after another unread updates are sent only after the last one with 5 seconds delay due to debouncing mechanism. Does this answer your question? |
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 126 ↗ | (On Diff #44345) | Sorry, this is my fault... I meant to ask about thin threads, but I wrote "thick threads" |
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 126 ↗ | (On Diff #44345) | Thin threads become read immediately after entering them. Thin threads are controlled by activity-handlers that communicate directly with the keyserver and work in a different way than this component. |
| lib/handlers/dm-activity-handler.js | ||
|---|---|---|
| 126 ↗ | (On Diff #44345) | Thanks for explaining! |