[lib] Disable editing failed messages
ClosedPublic
Actions

Authored by tomek on Sep 18 2024, 10:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 9:45 AM

	Unknown Object (File)
	Wed, Nov 20, 7:01 AM

	Unknown Object (File)
	Wed, Nov 20, 6:40 AM

	Unknown Object (File)
	Oct 22 2024, 10:41 AM

	Unknown Object (File)
	Oct 22 2024, 10:21 AM

	Unknown Object (File)
	Oct 22 2024, 10:21 AM

	Unknown Object (File)
	Oct 20 2024, 7:13 PM

	Unknown Object (File)
	Oct 15 2024, 3:29 AM

View All 33 Files

Subscribers

ashoat

Details

Reviewers

kamil
will

Commits

rCOMMead0ca12ea9b: [lib] Disable editing failed messages

Summary

https://linear.app/comm/issue/ENG-9333/disable-editing-failed-messages

Test Plan

On both native and web, in thin and thick thread check if the edit button is visible for successful messages and isn't shown for unsuccessful.

Diff Detail

Repository

rCOMM Comm

Branch

improvements2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 18 2024, 10:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 10:23 AM

Harbormaster completed remote builds in B31704: Diff 44319.Sep 18 2024, 10:41 AM

tomek requested review of this revision.Sep 18 2024, 10:41 AM

will accepted this revision.Sep 18 2024, 12:44 PM

This revision is now accepted and ready to land.Sep 18 2024, 12:44 PM

kamil accepted this revision.Sep 19 2024, 1:07 AM

Closed by commit rCOMMead0ca12ea9b: [lib] Disable editing failed messages (authored by tomek). · Explain WhySep 19 2024, 3:07 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMead0ca12ea9b: [lib] Disable editing failed messages.

Revision Contents
Changeset List

Path

Size

lib/

shared/

edit-messages-utils.js

2 lines

Diff 44319

View Options

lib/shared/edit-messages-utils.js

[lib] Disable editing failed messagesClosedPublicActions