Pass pairs of message data and raw message info to notif generation code
ClosedPublic
Actions

Authored by marcin on Sep 20 2024, 7:43 AM.

Details

Reviewers

tomek
kamil
ashoat

Commits

rCOMMcc116bc456de: Pass pairs of message data and raw message info to notif generation code

Summary

This differential modifies notif generation code to take pairs of message data and raw message info instead of message data alone to avoid issue of duplicated raw message info with different message id.

Test Plan

Ensure that those steps no longer introduce the bug.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Sep 20 2024, 7:43 AM

This differential is huge but logic is repetitive and each file can be reviewed independently. Adding many reviewers to get it reviewed urgently since it is a serious blocker for e2ee launch.

Harbormaster completed remote builds in B31753: Diff 44391.Sep 20 2024, 8:00 AM

marcin requested review of this revision.Sep 20 2024, 8:00 AM

I didn't review the changes to lib/shared/dm-ops very closely, as they seemed mostly rote

This revision is now accepted and ready to land.Sep 20 2024, 8:44 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Sep 20 2024, 12:46 PM

Closed by commit rCOMMcc116bc456de: Pass pairs of message data and raw message info to notif generation code (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMcc116bc456de: Pass pairs of message data and raw message info to notif generation code.

Harbormaster completed remote builds in B31757: Diff 44400.Sep 20 2024, 12:50 PM