Differential D13420

[web] Fix multimedia sending conditions for thick threads
ClosedPublic
Actions

Authored by bartek on Sep 23 2024, 2:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 15, 2:42 PM

	Unknown Object (File)
	Sat, Mar 15, 5:30 AM

	Unknown Object (File)
	Fri, Mar 14, 4:10 AM

	Unknown Object (File)
	Wed, Mar 5, 5:39 PM

	Unknown Object (File)
	Wed, Mar 5, 9:22 AM

	Unknown Object (File)
	Wed, Mar 5, 9:22 AM

	Unknown Object (File)
	Wed, Mar 5, 9:22 AM

	Unknown Object (File)
	Wed, Mar 5, 9:21 AM

View All 57 Files

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMM1e6ec1abd465: [web] Fix multimedia sending conditions for thick threads

Summary

Implements 2c from ENG-9345.
Details in the Linear comment.

Depends on D13419

Test Plan

Successfully sent a photo:

"quickly" (before upload finished) and "slowly" (waited until preload completes)
For thick and thin thread

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 23 2024, 2:06 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 23 2024, 2:06 AM

bartek published this revision for review.Sep 23 2024, 2:17 AM

bartek edited the summary of this revision. (Show Details)

bartek added a parent revision: D13419: [web] Skip `loop` property when dispatching updateMultimediaMessage.

bartek removed a parent revision: D13149: [lib] move generating P2P messages to `useProcessDMOperation`.

Harbormaster completed remote builds in B31760: Diff 44406.Sep 23 2024, 2:23 AM

kamil accepted this revision.Sep 23 2024, 2:42 AM

This revision is now accepted and ready to land.Sep 23 2024, 2:42 AM

Closed by commit rCOMM1e6ec1abd465: [web] Fix multimedia sending conditions for thick threads (authored by bartek). · Explain WhySep 23 2024, 7:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM1e6ec1abd465: [web] Fix multimedia sending conditions for thick threads.

Revision Contents
Changeset List

Path

Size

web/

input/

input-state-container.react.js

14 lines

1 line

Diff 44437

web/input/input-state-container.react.js

				locals {
				vpc_id = var.user_created_vpc ? aws_vpc.default[0].id : data.aws_vpc.default.id
				vpc_subnets = var.user_created_vpc ? [aws_subnet.public_1[0].id, aws_subnet.public_2[0].id] : [data.aws_subnets.default.ids[0], data.aws_subnets.default.ids[1]]
				}

	provider "aws" {			provider "aws" {
	region = var.region			region = var.region

	default_tags {			default_tags {
	tags = {			tags = {
	managed_by = "terraform"			managed_by = "terraform"
	}			}
	}			}
	}			}

web/input/input-state.js

				locals {
				vpc_id = var.user_created_vpc ? aws_vpc.default[0].id : data.aws_vpc.default.id
				vpc_subnets = var.user_created_vpc ? [aws_subnet.public_1[0].id, aws_subnet.public_2[0].id] : [data.aws_subnets.default.ids[0], data.aws_subnets.default.ids[1]]
				}

	provider "aws" {			provider "aws" {
	region = var.region			region = var.region

	default_tags {			default_tags {
	tags = {			tags = {
	managed_by = "terraform"			managed_by = "terraform"
	}			}
	}			}
	}			}