Page MenuHomePhabricator
Differential D13427

[lib] implement reply count for composable DM messages
ClosedPublic
Actions

Authored by kamil on Mon, Sep 23, 5:52 AM.
Tags
None
Referenced Files
F2838199: D13427.id44442.diff
Sat, Sep 28, 9:07 PM
F2837319: D13427.id44423.diff
Sat, Sep 28, 6:24 PM
Unknown Object (File)
Fri, Sep 27, 1:45 PM
Unknown Object (File)
Fri, Sep 27, 10:57 AM
Unknown Object (File)
Thu, Sep 26, 8:21 AM
Unknown Object (File)
Wed, Sep 25, 1:01 AM
Unknown Object (File)
Wed, Sep 25, 1:01 AM
Unknown Object (File)
Wed, Sep 25, 1:01 AM
View All 9 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM887af9313d3c: [lib] implement reply count for composable DM messages
Summary

ENG-9273.

Depends on D13426

Test Plan
  1. Reply count on sender.
  2. Reply count on receiver.
  3. Reply count when retrying.

Tested both web and native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Sep 23, 5:52 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMon, Sep 23, 5:52 AM
Harbormaster completed remote builds in B31775: Diff 44422.Mon, Sep 23, 6:17 AM
kamil published this revision for review.Mon, Sep 23, 6:21 AM
tomek accepted this revision.Mon, Sep 23, 6:38 AM
tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
323–329 ↗(On Diff #44422)

This probably can be simplified

This revision is now accepted and ready to land.Mon, Sep 23, 6:38 AM
kamil added inline comments.Mon, Sep 23, 8:33 AM
lib/shared/dm-ops/process-dm-ops.js
323–329 ↗(On Diff #44422)

There is the most readable way when Flow is not complaining

Closed by commit rCOMM887af9313d3c: [lib] implement reply count for composable DM messages (authored by kamil). · Explain WhyMon, Sep 23, 8:49 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM887af9313d3c: [lib] implement reply count for composable DM messages.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
26 lines

Diff 44441

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...