Page MenuHomePhabricator
Differential D13427

[lib] implement reply count for composable DM messages
ClosedPublic
Actions

Authored by kamil on Sep 23 2024, 5:52 AM.
Tags
None
Referenced Files
F3652910: D13427.id44441.diff
Sun, Jan 5, 8:21 AM
F3652892: D13427.id44422.diff
Sun, Jan 5, 8:20 AM
Unknown Object (File)
Thu, Jan 2, 5:23 AM
Unknown Object (File)
Thu, Dec 26, 11:23 PM
Unknown Object (File)
Thu, Dec 26, 11:22 PM
Unknown Object (File)
Tue, Dec 10, 5:18 AM
Unknown Object (File)
Dec 5 2024, 7:34 PM
Unknown Object (File)
Nov 25 2024, 7:57 AM
View All 37 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM887af9313d3c: [lib] implement reply count for composable DM messages
Summary

ENG-9273.

Depends on D13426

Test Plan
  1. Reply count on sender.
  2. Reply count on receiver.
  3. Reply count when retrying.

Tested both web and native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 23 2024, 5:52 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 23 2024, 5:52 AM
Harbormaster completed remote builds in B31775: Diff 44422.Sep 23 2024, 6:17 AM
kamil published this revision for review.Sep 23 2024, 6:21 AM
tomek accepted this revision.Sep 23 2024, 6:38 AM
tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
323–329 ↗(On Diff #44422)

This probably can be simplified

This revision is now accepted and ready to land.Sep 23 2024, 6:38 AM
kamil added inline comments.Sep 23 2024, 8:33 AM
lib/shared/dm-ops/process-dm-ops.js
323–329 ↗(On Diff #44422)

There is the most readable way when Flow is not complaining

Closed by commit rCOMM887af9313d3c: [lib] implement reply count for composable DM messages (authored by kamil). · Explain WhySep 23 2024, 8:49 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM887af9313d3c: [lib] implement reply count for composable DM messages.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
26 lines

Diff 44441

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...