[terraform] add backups to self-host aws rds
ClosedPublic
Actions

Authored by will on Sep 23 2024, 1:31 PM.

Details

Reviewers

bartek
varun

Commits

rCOMMae1d18eb5546: [terraform] add backups to self-host aws rds

Summary

A previous commit for this had to be reverted. AWS randomly chooses maintainence window times and my selected maintainence window and backup window overlapping, causing the terraform apply to fail.

This diff ensures they are specified differently.

Test Plan

terraform apply. Ensured backup modifications were completed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Sep 23 2024, 1:31 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 23 2024, 1:32 PM

Harbormaster completed remote builds in B31776: Diff 44423.Sep 23 2024, 1:49 PM

will requested review of this revision.Sep 23 2024, 1:49 PM

bartek accepted this revision.Sep 23 2024, 2:46 PM

bartek added inline comments.

services/terraform/self-host/aws_db.tf
49–50 ↗	(On Diff #44423)	These are UTC?

This revision is now accepted and ready to land.Sep 23 2024, 2:46 PM

will added inline comments.Sep 23 2024, 2:51 PM

services/terraform/self-host/aws_db.tf
49–50 ↗	(On Diff #44423)	Yep!

Closed by commit rCOMMae1d18eb5546: [terraform] add backups to self-host aws rds. · Explain WhySep 24 2024, 5:04 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMae1d18eb5546: [terraform] add backups to self-host aws rds.

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

aws_db.tf

37 lines

Diff 44452

View Options

services/terraform/self-host/aws_db.tf

[terraform] add backups to self-host aws rdsClosedPublicActions