Page MenuHomePhabricator
Differential D13459

[keyserver][lib] Don't return commbot -> admin report message from message report creator
ClosedPublic
Actions

Authored by ashoat on Sep 24 2024, 9:18 PM.
Tags
None
Referenced Files
F5101302: D13459.id.diff
Mon, Mar 31, 2:36 PM
F5095262: D13459.diff
Sun, Mar 30, 5:03 PM
Unknown Object (File)
Fri, Mar 28, 12:32 AM
Unknown Object (File)
Sat, Mar 15, 10:25 PM
Unknown Object (File)
Mon, Mar 3, 6:49 AM
Unknown Object (File)
Mon, Mar 3, 6:49 AM
Unknown Object (File)
Feb 28 2025, 2:09 AM
Unknown Object (File)
Jan 19 2025, 4:50 PM
View All 41 Files
Subscribers
None

Details

Reviewers
kamil
tomek
Commits
rCOMMee4699a2b140: [keyserver][lib] Don't return commbot -> admin report message from message…
Summary

There's no reason to send this to the reporter if they can't add it to their MessageStore.

Test Plan

Confirm that no message is returned and nothing breaks as a result

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
27 lines
lib/
reducers/
20 lines
types/
2 lines
validators/
6 lines

Diff 44524

View Options

keyserver/src/creators/message-report-creator.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

lib/reducers/message-reducer.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

lib/types/message-report-types.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

lib/types/validators/message-report-validators.js

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;