Page MenuHomePhabricator
Differential D13476

[native] add farcaster icon on native
ClosedPublic
Actions

Authored by varun on Sep 25 2024, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 9 2024, 3:56 AM
Unknown Object (File)
Nov 9 2024, 3:56 AM
Unknown Object (File)
Nov 9 2024, 3:55 AM
Unknown Object (File)
Nov 9 2024, 2:24 AM
Unknown Object (File)
Nov 1 2024, 12:37 PM
Unknown Object (File)
Nov 1 2024, 8:05 AM
Unknown Object (File)
Nov 1 2024, 5:36 AM
Unknown Object (File)
Oct 30 2024, 11:41 PM
View All 42 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
Commits
rCOMM18fde5a6777d: [native] add farcaster icon on native
Summary

missed this in my previous diff stack. we need to add the farcaster icon to icons to make it available in the action sheet.

i also resized the ethereum-outline icon because it looked too small

Depends on D13475

Test Plan

see attached photos. farcaster icon now appears in action sheet and the ethereum icon looks right

Screenshot_1727308308.png (3×1 px, 163 KB)

Screenshot_1727307971.png (3×1 px, 162 KB)

(simply replaced the icon name to test the ethereum icon size, not actually using that icon for the farcaster avatar option in action sheet)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 25 2024, 5:09 PM
varun held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 25 2024, 5:09 PM
varun edited the test plan for this revision. (Show Details)Sep 25 2024, 5:14 PM
varun attached a referenced file: F2810498: Screenshot_1727307971.png. (Show Details)
varun attached a referenced file: F2810499: Screenshot_1727308308.png. (Show Details)
varun published this revision for review.Sep 25 2024, 5:22 PM

will wait for CI to pass before landing

will accepted this revision.Sep 25 2024, 5:22 PM
This revision is now accepted and ready to land.Sep 25 2024, 5:22 PM
Harbormaster completed remote builds in B31862: Diff 44577.Sep 25 2024, 5:27 PM
Closed by commit rCOMM18fde5a6777d: [native] add farcaster icon on native (authored by varun). · Explain WhySep 25 2024, 5:29 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM18fde5a6777d: [native] add farcaster icon on native.
ashoat added a comment.Sep 25 2024, 5:54 PM

Why does the home pill appear over the options? Do we need to wrap something in a SafeAreaView?

varun added a comment.EditedSep 25 2024, 8:52 PM
In D13476#378823, @ashoat wrote:

Why does the home pill appear over the options? Do we need to wrap something in a SafeAreaView?

thanks for pointing that out. D13477

Revision Contents
Changeset List

PathSize
native/
avatars/
11 lines

Diff 44579

View Options

native/avatars/avatar-hooks.js

Loading...