[lib] Validate DM operations
ClosedPublic
Actions

Authored by tomek on Thu, Sep 26, 3:14 AM.

Details

Reviewers

kamil
will

Commits

rCOMM23ee267213b4: [lib] Validate DM operations

Summary

Add an explicit validation with some logs.

https://linear.app/comm/issue/ENG-9190/alternative-solution-update-canbeprocessed-functions

Depends on D13464

Test Plan

Clicked through the app and verified that e.g. sending text messages, reacting, and creating sidebars work.
Created some invalid operations from code and checked if it is discarded.

Diff Detail

Repository

rCOMM Comm

Branch

improvements2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Thu, Sep 26, 3:14 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Sep 26, 3:14 AM

Harbormaster completed remote builds in B31873: Diff 44591.Thu, Sep 26, 3:31 AM

tomek requested review of this revision.Thu, Sep 26, 3:31 AM

tomek added a child revision: D13490: [lib] Handle a case where viewer is added to a thread while being its member.Thu, Sep 26, 4:16 AM

kamil accepted this revision.Thu, Sep 26, 7:35 AM

This revision is now accepted and ready to land.Thu, Sep 26, 7:35 AM

Rebase

Harbormaster completed remote builds in B31897: Diff 44622.Fri, Sep 27, 3:39 AM

Closed by commit rCOMM23ee267213b4: [lib] Validate DM operations (authored by tomek). · Explain WhyFri, Sep 27, 3:54 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM23ee267213b4: [lib] Validate DM operations.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

add-members-spec.js

6 lines

add-viewer-to-thread-members-spec.js

6 lines

change-thread-read-status-spec.js

8 lines

change-thread-settings-spec.js

10 lines

change-thread-subscription.js

6 lines

create-entry-spec.js

6 lines

create-sidebar-spec.js

6 lines

create-thread-spec.js

8 lines

6 lines

3 lines

6 lines

6 lines

6 lines

5 lines

remove-members-spec.js

6 lines

send-edit-message-spec.js

6 lines

send-multimedia-message-spec.js

8 lines

send-reaction-message-spec.js

6 lines

send-text-message-spec.js

6 lines

update-relationship-spec.js

6 lines

Diff 44591

View Options

lib/shared/dm-ops/add-members-spec.js

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

View Options

lib/shared/dm-ops/change-thread-settings-spec.js

View Options

lib/shared/dm-ops/change-thread-subscription.js

View Options

lib/shared/dm-ops/create-entry-spec.js

View Options

lib/shared/dm-ops/create-sidebar-spec.js

View Options

lib/shared/dm-ops/create-thread-spec.js

View Options

lib/shared/dm-ops/delete-entry-spec.js

View Options

lib/shared/dm-ops/dm-op-spec.js

View Options

lib/shared/dm-ops/edit-entry-spec.js

View Options

lib/shared/dm-ops/join-thread-spec.js

View Options

lib/shared/dm-ops/leave-thread-spec.js

View Options

lib/shared/dm-ops/process-dm-ops.js

View Options

lib/shared/dm-ops/remove-members-spec.js

View Options

lib/shared/dm-ops/send-edit-message-spec.js

View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

View Options

lib/shared/dm-ops/send-reaction-message-spec.js

View Options

lib/shared/dm-ops/send-text-message-spec.js

View Options

lib/shared/dm-ops/update-relationship-spec.js

[lib] Validate DM operationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44591

lib/shared/dm-ops/add-members-spec.js

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

lib/shared/dm-ops/change-thread-read-status-spec.js

lib/shared/dm-ops/change-thread-settings-spec.js

lib/shared/dm-ops/change-thread-subscription.js

lib/shared/dm-ops/create-entry-spec.js

lib/shared/dm-ops/create-sidebar-spec.js

lib/shared/dm-ops/create-thread-spec.js

lib/shared/dm-ops/delete-entry-spec.js

lib/shared/dm-ops/dm-op-spec.js

lib/shared/dm-ops/edit-entry-spec.js

lib/shared/dm-ops/join-thread-spec.js

lib/shared/dm-ops/leave-thread-spec.js

lib/shared/dm-ops/process-dm-ops.js

lib/shared/dm-ops/remove-members-spec.js

lib/shared/dm-ops/send-edit-message-spec.js

lib/shared/dm-ops/send-multimedia-message-spec.js

lib/shared/dm-ops/send-reaction-message-spec.js

lib/shared/dm-ops/send-text-message-spec.js

lib/shared/dm-ops/update-relationship-spec.js

[lib] Validate DM operations
ClosedPublic
Actions

Revision Contents
Changeset List