Page MenuHomePhabricator

[native] handle missing neynar config in registration
ClosedPublic

Authored by varun on Sep 26 2024, 8:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Wed, Oct 30, 2:21 PM
Unknown Object (File)
Sun, Oct 27, 2:20 AM
Unknown Object (File)
Sun, Oct 27, 2:20 AM
Unknown Object (File)
Sun, Oct 27, 2:19 AM
Unknown Object (File)
Sun, Oct 27, 2:16 AM
Unknown Object (File)
Oct 14 2024, 3:26 PM
Unknown Object (File)
Oct 13 2024, 10:50 AM
Subscribers

Details

Summary

devs might not have the neynar.json file required to construct the neynar client. if the client doesn't exist, we use the fallback function to make the getFCAvatarURLs call.

Test Plan

removed my neynar.json file and was able to register successfully. as expected, there was no farcaster avatar option available despite connecting my farcaster account. this is because the neynar client cannot be constructed without the json file.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun published this revision for review.Sep 26 2024, 8:23 AM

will wait for CI before landing

ashoat added inline comments.
native/account/registration/connect-farcaster.react.js
134–135 ↗(On Diff #44604)

Does Flow complain if you remove these lines?

136–138 ↗(On Diff #44604)
This revision is now accepted and ready to land.Sep 26 2024, 9:15 AM
native/account/registration/connect-farcaster.react.js
134–135 ↗(On Diff #44604)

Yeah it does