[lib] Update pending thread type based on selected members
ClosedPublic
Actions

Authored by tomek on Sep 30 2024, 5:21 AM.

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMMbe3e464a7a23: [lib] Update pending thread type based on selected members

Summary

Every time a list of selected users change check whether they support thick threads and update the type accordingly. Checking the support is an asynchronous operation which causes a lot of changes in other places.

https://linear.app/comm/issue/ENG-9393/update-pending-thread-type-based-on-selected-members

Depends on D13489

Test Plan

Modify useUserSupportThickThread so that it returns false for some users. Check if the thread type is determined correctly on native and web.

Tested following scenarios

Searching for a user on native with useUserSupportThickThread modified to return false for some users
Searching for a user on native without modifications to useUserSupportThickThread
Searching for a user on web with useUserSupportThickThread modified to return false for some users
Searching for a user on web without modifications to useUserSupportThickThread
Composing a thread on native with useUserSupportThickThread modified to return false for some users
Composing a thread on native without modifications to useUserSupportThickThread
Composing a thread on web with useUserSupportThickThread modified to return false for some users
Composing a thread on web without modifications to useUserSupportThickThread

For each of these verified that the thread type is displayed correctly and that sending a message results in the creation of the correct thread type.

Diff Detail

Repository

rCOMM Comm

Branch

thread-types

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 30 2024, 5:21 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 30 2024, 5:21 AM

tomek edited the test plan for this revision. (Show Details)Sep 30 2024, 5:21 AM

Harbormaster completed remote builds in B31929: Diff 44678.Sep 30 2024, 5:37 AM

tomek requested review of this revision.Sep 30 2024, 5:37 AM

Rebase

Harbormaster completed remote builds in B31931: Diff 44682.Sep 30 2024, 6:00 AM

Can you update the test plan to cover all of these scenarios?

Searching for a user on native with useUserSupportThickThread modified to return false for some users
Searching for a user on native without modifications to useUserSupportThickThread
Searching for a user on web with useUserSupportThickThread modified to return false for some users
Searching for a user on web without modifications to useUserSupportThickThread
Composing a thread on native with useUserSupportThickThread modified to return false for some users
Composing a thread on native without modifications to useUserSupportThickThread
Composing a thread on web with useUserSupportThickThread modified to return false for some users
Composing a thread on web without modifications to useUserSupportThickThread

This revision is now accepted and ready to land.Sep 30 2024, 6:01 AM

In D13519#379786, @ashoat wrote:

Can you update the test plan to cover all of these scenarios?

Searching for a user on native with useUserSupportThickThread modified to return false for some users

Searching for a user on native without modifications to useUserSupportThickThread

Searching for a user on web with useUserSupportThickThread modified to return false for some users

Searching for a user on web without modifications to useUserSupportThickThread

Composing a thread on native with useUserSupportThickThread modified to return false for some users

Composing a thread on native without modifications to useUserSupportThickThread

Composing a thread on web with useUserSupportThickThread modified to return false for some users

Composing a thread on web without modifications to useUserSupportThickThread