[native] Fail initializeCryptoAccount when exception thrown before cryptoJob
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 12:12 PM.

Details

Reviewers

will
varun

Commits

rCOMM8c10b49b07ec: [native] Fail initializeCryptoAccount when exception thrown before cryptoJob

Summary

Right now we catch this error but don't do anything. This seems like buggy code... we should probably reject the promise.

Depends on D13525

Test Plan

I tested using this patch and confirmed that the exception is thrown

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 12:12 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 30 2024, 12:12 PM

ashoat added a child revision: D13527: [native] Combine invokeAsync calls at the end of initializeCryptoAccount.Sep 30 2024, 12:13 PM

Harbormaster completed remote builds in B31941: Diff 44698.Sep 30 2024, 12:30 PM

ashoat requested review of this revision.Sep 30 2024, 12:30 PM

will accepted this revision.Sep 30 2024, 3:35 PM

This revision is now accepted and ready to land.Sep 30 2024, 3:35 PM

Closed by commit rCOMM8c10b49b07ec: [native] Fail initializeCryptoAccount when exception thrown before cryptoJob (authored by ashoat). · Explain WhySep 30 2024, 4:49 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8c10b49b07ec: [native] Fail initializeCryptoAccount when exception thrown before cryptoJob.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.cpp

9 lines

Diff 44707

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[native] Fail initializeCryptoAccount when exception thrown before cryptoJobClosedPublicActions