[web] Update serverID for pendingUploads after reassignment
ClosedPublic
Actions

Authored by bartek on Oct 1 2024, 3:54 AM.

Details

Reviewers

kamil
ashoat

Commits

rCOMMf6cdbd8d04b2: [web] Update serverID for pendingUploads after reassignment

Summary

Follow up https://phab.comm.dev/D13501?id=44638#inline-77322

Depends on D13555

Test Plan

Printed pendingUploads in setState callback. Started thread with a user without CSAT by sending multimedia. Confirmed that upload serverID is updated to a keyserver ID.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Oct 1 2024, 3:54 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptOct 1 2024, 3:54 AM

Harbormaster completed remote builds in B31978: Diff 44744.Oct 1 2024, 4:10 AM

Rebase

Harbormaster completed remote builds in B31979: Diff 44745.Oct 1 2024, 5:01 AM

bartek published this revision for review.Oct 1 2024, 5:48 AM

ashoat added inline comments.Oct 1 2024, 5:50 AM

web/input/input-state-container.react.js
572–581 ↗	(On Diff #44745)	Why are we sure that we only need to modify this info in the case of `!uriIsReal`?

How about native?

In D13556#380358, @ashoat wrote:

How about native?

I checked native too. Confirmed what I was thinking initially in https://phab.comm.dev/D13501?id=44638#inline-77322:

I haven't found any reason to do it on native though

web/input/input-state-container.react.js
572–581 ↗	(On Diff #44745)	If `uriIsReal`, this code originally skips creating `newUploads` for this particular upload, effectively removing it from state. If we send a message while uri is not yet real (media is not yet preloaded), we assign `messageID` (and now `serverID`) to it and keep the upload. I checked it and without this condition, a new invalid `pendingUpload` is created with only two properties: `messageID` and `serverID`.