[lib] fix `PushHandler` to support DMs
ClosedPublic
Actions

Authored by tomek on Wed, Oct 2, 8:58 AM.

Details

Reviewers

ashoat
kamil

Commits

rCOMMd304b0bc35f4: [lib] fix `PushHandler` to support DMs

Summary

Solution described in ENG-9465.

Test Plan

Apply this diff:

Comment this line to make sure we're testing actual notifs code & add some logs to make sure code in reducer was executed.
Open physical device
In DM thread send a test message
Notif delivered
Message immediately visible in UI
Thread marked as unread
Logs from reducer are there

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

kamil published this revision for review.Wed, Oct 2, 8:59 AM

tomek added inline comments.

lib/reducers/thread-reducer.js
338	When `threadInfo.currentUser.unread` we should bump the timestamp.
341–342	Might be a good idea to reference in `getThreadUpdatesForNewMessages` this place.

This revision is now accepted and ready to land.Wed, Oct 2, 9:06 AM

lib/reducers/thread-reducer.js
341–342	I'm confused why we'd want to set the thread to `unread` even if the timestamp is newer than the message timestamp What's the benefit of this? Doesn't it introduce a risk of setting something to `unread` incorrectly if a notif for message X is received after a Tunnelbroker message is received for message X?