Page MenuHomePhabricator

[keyserver] Show the most recent thread when opening the web app without providing a thread ID
ClosedPublic

Authored by tomek on Oct 3 2024, 7:52 AM.
Tags
None
Referenced Files
F3336000: D13590.diff
Thu, Nov 21, 1:28 PM
Unknown Object (File)
Wed, Nov 13, 12:03 AM
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Sun, Nov 10, 1:53 PM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
Unknown Object (File)
Fri, Nov 8, 1:49 PM
Unknown Object (File)
Mon, Nov 4, 10:25 AM
Unknown Object (File)
Fri, Nov 1, 2:27 PM
Subscribers

Details

Summary

The most recent thread can be thick and the keyserver doesn't know about it. In this case we can rely on the app to compute the activeChatThreadID instead of the keyserver. In validateStateAndQueueOpsProcessing we're handling an empty state.navInfo.activeChatThreadID by calling mostRecentlyReadThreadSelector. This means that we can simply stop handling empty activeChatThreadID on the keyserver side.

https://linear.app/comm/issue/ENG-9126/opening-a-link-to-the-chat-doesnt-open-the-most-recent-thick-thread

Test Plan

Made sure that the most recent thread is thick. Opened /webapp and /webapp/chat and verified that the most recent thread is shown.
Updated the state so that a thin thread is the most recent and performed the same test.
Made sure that opening a link to a thin and to a thick thread still opens it even if it isn't the most recent.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage