Page MenuHomePhabricator
Differential D13620

[landing] Fix ConnectFarcaster
ClosedPublic
Actions

Authored by ashoat on Fri, Oct 4, 3:31 PM.

Details

Reviewers
varun
will
Commits
rCOMM25c1c1f67952: [landing] Fix ConnectFarcaster
Summary

Addresses ENG-9506. @horsefacts helped me out here. We should be waiting for connect to finish before calling signIn.

Test Plan

I tested the SIWF flow on Android following this doc

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Fri, Oct 4, 3:31 PM
Herald added a subscriber: tomek. · View Herald TranscriptFri, Oct 4, 3:31 PM
ashoat published this revision for review.Fri, Oct 4, 3:32 PM
varun accepted this revision.Fri, Oct 4, 3:32 PM
This revision is now accepted and ready to land.Fri, Oct 4, 3:32 PM
ashoat edited the summary of this revision. (Show Details)Fri, Oct 4, 3:33 PM
This revision was landed with ongoing or failed builds.Fri, Oct 4, 3:41 PM
Closed by commit rCOMM25c1c1f67952: [landing] Fix ConnectFarcaster (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM25c1c1f67952: [landing] Fix ConnectFarcaster.
Harbormaster completed remote builds in B32083: Diff 44917.Fri, Oct 4, 3:49 PM

Revision Contents
Changeset List

PathSize
landing/
10 lines

Diff 44917

View Options

landing/connect-farcaster.react.js

Loading...