Paths

Table of Contentst

Differential D13624

[landing] Make buttons variable width
ClosedPublic
Actions

Authored by ashoat on Mon, Oct 7, 12:06 PM.

Tags

None

Referenced Files

	F2925319: D13624.diff
	Tue, Oct 8, 5:47 AM

	F2924450: D13624.id44946.diff
	Tue, Oct 8, 12:46 AM

	Unknown Object (File)
	Mon, Oct 7, 4:32 PM

	F2919757: Screenshot 2024-10-07 at 4.00.29 PM.png
	Mon, Oct 7, 1:01 PM

	F2919011: Screenshot 2024-10-07 at 3.40.08 PM.png
	Mon, Oct 7, 12:40 PM

	F2918723: Screenshot 2024-10-07 at 3.09.14 PM.png
	Mon, Oct 7, 12:10 PM

	F2918693: Screenshot 2024-10-07 at 3.05.20 PM.png
	Mon, Oct 7, 12:09 PM

	F2918692: Screenshot 2024-10-07 at 3.08.46 PM.png
	Mon, Oct 7, 12:09 PM

View All 9 Files

Subscribers

Details

Reviewers

Commits

rCOMM310fd6416738: [landing] Make buttons variable width

Summary

The <Button> component in landing is used in two places:

It's used in the team page. From testing on Chrome, I can see that flex-basis has no effect there. Chrome explains why:
The main use is the download page. I'm about to introduce a new button, so I actually want to change the grid layout there. See test plan for before/after

Test Plan

Check how team and download pages look in my local dev environment

before	after

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Oct 7, 12:06 PM

Herald added a subscriber: tomek. · View Herald TranscriptMon, Oct 7, 12:06 PM

ashoat edited the summary of this revision. (Show Details)Mon, Oct 7, 12:09 PM

ashoat edited the test plan for this revision. (Show Details)

ashoat added inline comments.

landing/download.css
28 ↗	(On Diff #44946)	Without this change, we see the following:

ashoat attached a referenced file: F2918723: Screenshot 2024-10-07 at 3.09.14 PM.png. (Show Details)Mon, Oct 7, 12:10 PM

ashoat added a child revision: D13625: [landing] Add link to web app from download page.Mon, Oct 7, 12:14 PM

Harbormaster completed remote builds in B32090: Diff 44946.Mon, Oct 7, 12:24 PM

ashoat requested review of this revision.Mon, Oct 7, 12:24 PM

Just looked at the download page on safari and it looks really bad right now:

Screenshot 2024-10-07 at 3.40.08 PM.png (1×1 px, 85 KB)

Can you confirm before landing that your changes fix this issue, too?

This revision is now accepted and ready to land.Mon, Oct 7, 12:40 PM

Yeah that's flex-basis: 120px; for sure. Here's what it looks like now in Safari:

Screenshot 2024-10-07 at 4.00.29 PM.png (458×914 px, 46 KB)

thanks!

Closed by commit rCOMM310fd6416738: [landing] Make buttons variable width (authored by ashoat). · Explain WhyMon, Oct 7, 1:03 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM310fd6416738: [landing] Make buttons variable width.

Revision Contents
Changeset List

Path

Size

landing/

1 line

1 line

Diff 44954

landing/button.css

Loading...

landing/download.css

Loading...