Page MenuHomePhabricator

[landing] Make buttons variable width
ClosedPublic

Authored by ashoat on Mon, Oct 7, 12:06 PM.
Tags
None
Referenced Files
F2925319: D13624.diff
Tue, Oct 8, 5:47 AM
F2924450: D13624.id44946.diff
Tue, Oct 8, 12:46 AM
Unknown Object (File)
Mon, Oct 7, 4:32 PM
F2919757: Screenshot 2024-10-07 at 4.00.29 PM.png
Mon, Oct 7, 1:01 PM
F2919011: Screenshot 2024-10-07 at 3.40.08 PM.png
Mon, Oct 7, 12:40 PM
F2918723: Screenshot 2024-10-07 at 3.09.14 PM.png
Mon, Oct 7, 12:10 PM
F2918693: Screenshot 2024-10-07 at 3.05.20 PM.png
Mon, Oct 7, 12:09 PM
F2918692: Screenshot 2024-10-07 at 3.08.46 PM.png
Mon, Oct 7, 12:09 PM
Subscribers

Details

Summary

The <Button> component in landing is used in two places:

  1. It's used in the team page. From testing on Chrome, I can see that flex-basis has no effect there. Chrome explains why:
    Screenshot 2024-10-07 at 3.03.36 PM.png (936×1 px, 242 KB)
  2. The main use is the download page. I'm about to introduce a new button, so I actually want to change the grid layout there. See test plan for before/after
Test Plan

Check how team and download pages look in my local dev environment

beforeafter
Screenshot 2024-10-07 at 3.08.46 PM.png (462×658 px, 34 KB)
Screenshot 2024-10-07 at 3.05.20 PM.png (462×634 px, 35 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/landing
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat edited the test plan for this revision. (Show Details)
ashoat added inline comments.
landing/download.css
28

Without this change, we see the following:

Screenshot 2024-10-07 at 3.09.14 PM.png (434×610 px, 34 KB)

Just looked at the download page on safari and it looks really bad right now:

Screenshot 2024-10-07 at 3.40.08 PM.png (1×1 px, 85 KB)

Can you confirm before landing that your changes fix this issue, too?

This revision is now accepted and ready to land.Mon, Oct 7, 12:40 PM

Yeah that's flex-basis: 120px; for sure. Here's what it looks like now in Safari:

Screenshot 2024-10-07 at 4.00.29 PM.png (458×914 px, 46 KB)

This revision was automatically updated to reflect the committed changes.