Page MenuHomePhabricator

[lib] Remove !threadInfos check from BaseAutoJoinCommunityHandler
ClosedPublic

Authored by ashoat on Oct 7 2024, 12:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 5:44 AM
Unknown Object (File)
Fri, Nov 15, 12:14 PM
Unknown Object (File)
Fri, Nov 15, 4:11 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 2:22 AM
Unknown Object (File)
Mon, Nov 4, 10:19 PM
Unknown Object (File)
Sat, Nov 2, 10:37 PM
Unknown Object (File)
Sat, Nov 2, 12:21 AM
Subscribers

Details

Summary

Ginsu added this check in this revision of the diff that first introduced this code.

My understanding is that threadInfos should always be set, and that's how we treat it elsewhere in the codebase. I think it's safe to remove this check.

Test Plan

Flow, and also checking with Ginsu about why he added the check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable