[lib] Remove !threadInfos check from BaseAutoJoinCommunityHandler
ClosedPublic
Actions

Authored by ashoat on Mon, Oct 7, 12:31 PM.

Details

Reviewers

varun

Commits

rCOMM8b38974652bd: [lib] Remove !threadInfos check from BaseAutoJoinCommunityHandler

Summary

Ginsu added this check in this revision of the diff that first introduced this code.

My understanding is that threadInfos should always be set, and that's how we treat it elsewhere in the codebase. I think it's safe to remove this check.

Test Plan

Flow, and also checking with Ginsu about why he added the check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mon, Oct 7, 12:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptMon, Oct 7, 12:31 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Oct 7, 12:32 PM

Harbormaster failed remote builds in B32092: Diff 44948!

ashoat added a child revision: D13627: [lib] Replace loggedIn check with canQuery in BaseAutoJoinCommunityHandler.Mon, Oct 7, 12:33 PM

Retry CI

From Ginsu:

Harbormaster completed remote builds in B32096: Diff 44952.Mon, Oct 7, 1:17 PM

ashoat requested review of this revision.Mon, Oct 7, 1:17 PM

varun accepted this revision.Mon, Oct 7, 4:58 PM

This revision is now accepted and ready to land.Mon, Oct 7, 4:58 PM

Closed by commit rCOMM8b38974652bd: [lib] Remove !threadInfos check from BaseAutoJoinCommunityHandler (authored by ashoat). · Explain WhyMon, Oct 7, 6:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8b38974652bd: [lib] Remove !threadInfos check from BaseAutoJoinCommunityHandler.

Revision Contents
Changeset List

Path

Size

lib/

components/

base-auto-join-community-handler.react.js

2 lines

Diff 44956

View Options

lib/components/base-auto-join-community-handler.react.js

[lib] Remove !threadInfos check from BaseAutoJoinCommunityHandlerClosedPublicActions