[lib] Replace loggedIn check with canQuery in BaseAutoJoinCommunityHandler
ClosedPublic
Actions

Authored by ashoat on Oct 7 2024, 12:33 PM.

Details

Reviewers

varun

Commits

rCOMM1118e261635f: [lib] Replace loggedIn check with canQuery in BaseAutoJoinCommunityHandler

Summary

This diff is a no-op, as canQuery is set to loggedIn above. I'm simplifying the code ahead of the next diff.

Depends on D13626

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/autojoin

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 7 2024, 12:33 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 7 2024, 12:33 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 7 2024, 12:33 PM

Harbormaster failed remote builds in B32093: Diff 44949!

ashoat added a child revision: D13628: [lib] Restart BaseAutoJoinCommunityHandler when FID changes.Oct 7 2024, 12:37 PM

Retry CI

Harbormaster completed remote builds in B32097: Diff 44953.Oct 7 2024, 1:16 PM

ashoat requested review of this revision.Oct 7 2024, 1:16 PM

varun accepted this revision.Oct 7 2024, 4:59 PM

This revision is now accepted and ready to land.Oct 7 2024, 4:59 PM

Closed by commit rCOMM1118e261635f: [lib] Replace loggedIn check with canQuery in BaseAutoJoinCommunityHandler (authored by ashoat). · Explain WhyOct 7 2024, 6:14 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1118e261635f: [lib] Replace loggedIn check with canQuery in BaseAutoJoinCommunityHandler.

Revision Contents
Changeset List

Path

Size

lib/

components/

base-auto-join-community-handler.react.js

3 lines

Diff 44949

View Options

lib/components/base-auto-join-community-handler.react.js

[lib] Replace loggedIn check with canQuery in BaseAutoJoinCommunityHandlerClosedPublicActions