Differential D13628

[lib] Restart BaseAutoJoinCommunityHandler when FID changes
ClosedPublic
Actions

Authored by ashoat on Oct 7 2024, 7:37 PM.

Details

Reviewers

varun

Commits

rCOMM836305a236ff: [lib] Restart BaseAutoJoinCommunityHandler when FID changes

Summary

This diff addresses ENG-9539.

Depends on D13627

Test Plan

To be honest, I haven't tested this... I think the change is pretty predictable and safe

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/autojoin

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 7 2024, 7:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 7 2024, 7:37 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 7 2024, 7:39 PM

Harbormaster failed remote builds in B32094: Diff 44950!

Retry CI

Harbormaster completed remote builds in B32095: Diff 44951.Oct 7 2024, 8:14 PM

ashoat requested review of this revision.Oct 7 2024, 8:14 PM

varun accepted this revision.Oct 8 2024, 12:05 AM

This revision is now accepted and ready to land.Oct 8 2024, 12:05 AM

Closed by commit rCOMM836305a236ff: [lib] Restart BaseAutoJoinCommunityHandler when FID changes. · Explain WhyOct 8 2024, 1:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM836305a236ff: [lib] Restart BaseAutoJoinCommunityHandler when FID changes.

Revision Contents
Changeset List

Path

Size

lib/

components/

base-auto-join-community-handler.react.js

2 lines

Diff 44951

View Options

lib/components/base-auto-join-community-handler.react.js

[lib] Restart BaseAutoJoinCommunityHandler when FID changesClosedPublicActions