Page MenuHomePhabricator

[native] Upgrade to react-native@0.70.15
ClosedPublic

Authored by ashoat on Sat, Oct 12, 12:14 PM.
Tags
None
Referenced Files
F2983093: D13700.diff
Wed, Oct 16, 7:22 AM
F2976411: D13700.id.diff
Tue, Oct 15, 9:03 AM
Unknown Object (File)
Mon, Oct 14, 4:47 AM
Unknown Object (File)
Sat, Oct 12, 8:33 PM
Unknown Object (File)
Sat, Oct 12, 8:33 PM
Unknown Object (File)
Sat, Oct 12, 8:32 PM
Unknown Object (File)
Sat, Oct 12, 5:25 PM
Unknown Object (File)
Sat, Oct 12, 4:14 PM
Subscribers

Details

Summary

Was investigating if this introduce support in Hermes for named capture groups to address some issues integrating Viem in ENG-5308. It didn't end up helping, but I figured I'd put the diff up anyways.

Test Plan

Before landing, will confirm it passes CI, and that iOS / Android builds on dev / release

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/basenames
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sat, Oct 12, 12:30 PM
Harbormaster failed remote builds in B32201: Diff 45097!
Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Oct 13, 3:02 PM
Harbormaster failed remote builds in B32204: Diff 45100!
ashoat edited the test plan for this revision. (Show Details)
native/ios/Podfile
89–91 ↗(On Diff #45131)

Context on why we can remove these lines is here

native/package.json
81 ↗(On Diff #45131)

Context on why this upgrade was necessary here

This revision is now accepted and ready to land.Mon, Oct 14, 7:28 AM
This revision was automatically updated to reflect the committed changes.