Paths

Table of Contentst

Differential D13713

Rename notificationSizeValidator to isNotificationSizeValid
ClosedPublic
Actions

Authored by angelika on Oct 15 2024, 5:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 2:11 AM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Sat, Nov 16, 10:47 AM

	Unknown Object (File)
	Fri, Nov 15, 7:06 AM

View All 76 Files

Subscribers

Details

Reviewers

ashoat
kamil

Commits

rCOMMa8b8ff0d0f40: Rename notificationSizeValidator to isNotificationSizeValid

Summary

Rename notificationSizeValidator function to make it more obvious it returns true if size is valid.

Depends on D13712

Test Plan

Create chat
Verify that notifications are still working

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

angelika created this revision.Oct 15 2024, 5:32 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 15 2024, 5:32 AM

angelika added reviewers: ashoat, kamil.Oct 15 2024, 5:33 AM

angelika edited the summary of this revision. (Show Details)Oct 15 2024, 5:35 AM

angelika added a parent revision: D13712: Fix payloadSizeExceeded calculated incorrectly.

angelika mentioned this in D13712: Fix payloadSizeExceeded calculated incorrectly.

Harbormaster completed remote builds in B32250: Diff 45195.Oct 15 2024, 6:05 AM

angelika requested review of this revision.Oct 15 2024, 6:05 AM

Thanks for doing this!

This revision is now accepted and ready to land.Oct 15 2024, 9:26 AM

Fix also Android functions

You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again

arc diff basically checks the "Differential Revision: " line of the most recent commit, and updates the corresponding Phabricator diff to match that commit.

Rebase

In D13713#383795, @ashoat wrote:

You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again

arc diff basically checks the "Differential Revision: " line of the most recent commit, and updates the corresponding Phabricator diff to match that commit.

Yes, I know I messed something up 😅 I'm still learning this diff stuff, but now it should be ok 🙏

Harbormaster completed remote builds in B32256: Diff 45208.Oct 15 2024, 3:02 PM

Harbormaster completed remote builds in B32258: Diff 45210.Oct 15 2024, 3:10 PM

Closed by commit rCOMMa8b8ff0d0f40: Rename notificationSizeValidator to isNotificationSizeValid (authored by angelika). · Explain WhyOct 16 2024, 4:51 AM

This revision was automatically updated to reflect the committed changes.

angelika mentioned this in rCOMM9f1950582fea: Fix payloadSizeExceeded calculated incorrectly.

angelika added a commit: rCOMMa8b8ff0d0f40: Rename notificationSizeValidator to isNotificationSizeValid.

Revision Contents
Changeset List

Path

Size

lib/

push/

apns-notif-creators.js

6 lines

44 lines

Diff 45219

lib/push/apns-notif-creators.js

Loading...

lib/push/crypto.js

Loading...