Rename notificationSizeValidator to isNotificationSizeValid
AcceptedPublic
Actions

Authored by angelika on Tue, Oct 15, 5:32 AM.

Details

Reviewers

ashoat
kamil

Summary

Rename notificationSizeValidator function to make it more obvious it returns true if size is valid.

Depends on D13712

Test Plan

Create chat
Verify that notifications are still working

Diff Detail

Repository

rCOMM Comm

Branch

@graszka22/ENG-9376

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Tue, Oct 15, 5:32 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Oct 15, 5:32 AM

angelika added reviewers: ashoat, kamil.Tue, Oct 15, 5:33 AM

angelika edited the summary of this revision. (Show Details)Tue, Oct 15, 5:35 AM

angelika added a parent revision: D13712: Fix payloadSizeExceeded calculated incorrectly.

angelika mentioned this in D13712: Fix payloadSizeExceeded calculated incorrectly.

Harbormaster completed remote builds in B32250: Diff 45195.Tue, Oct 15, 6:05 AM

angelika requested review of this revision.Tue, Oct 15, 6:05 AM

Thanks for doing this!

This revision is now accepted and ready to land.Tue, Oct 15, 9:26 AM

Fix also Android functions

You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again

arc diff basically checks the "Differential Revision: " line of the most recent commit, and updates the corresponding Phabricator diff to match that commit.

Rebase

In D13713#383795, @ashoat wrote:

You updated the wrong diff – this can happen if you don't rebase back to the original diff before running arc diff again

arc diff basically checks the "Differential Revision: " line of the most recent commit, and updates the corresponding Phabricator diff to match that commit.

Yes, I know I messed something up 😅 I'm still learning this diff stuff, but now it should be ok 🙏

Harbormaster completed remote builds in B32256: Diff 45208.Tue, Oct 15, 3:02 PM

Harbormaster completed remote builds in B32258: Diff 45210.Tue, Oct 15, 3:10 PM