Page MenuHomePhabricator

[lib] Disconnect FID when another device disconnects it
ClosedPublic

Authored by ashoat on Oct 15 2024, 11:27 AM.
Tags
None
Referenced Files
F3305838: D13716.id45205.diff
Mon, Nov 18, 4:30 PM
Unknown Object (File)
Sat, Nov 16, 10:48 AM
Unknown Object (File)
Sat, Nov 16, 10:48 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Sat, Nov 16, 10:47 AM
Unknown Object (File)
Sun, Nov 3, 10:34 PM
Unknown Object (File)
Sun, Nov 3, 9:57 PM
Unknown Object (File)
Sun, Nov 3, 9:21 PM
Subscribers

Details

Summary

This addresses ENG-9684.

Depends on D13715

Test Plan
  1. I started with a test account that has been connected to an FID on staging
  2. I opened up a mobile app and a web app logged in as this user
  3. I disconnected the FID on mobile
  4. I refreshed the web app. Prior to these changes, refreshing would not cause the FID to be disconnected on web. After these changes, it does. I was able to check if the FID was connected by seeing if the “Tag Farcaster channel” option appeared for a community that the user is an admin of
  5. On mobile, I then reconnected the FID on staging following these instructions
  6. After reconnecting on mobile, I refreshed the web app and confirmed that the FID was reconnected on web too
  7. Then I added an artificial delay to the findUserIdentities RPC to force a timeout. I refreshed the web app and confirmed that the FID was *not* disconnected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lib/components/farcaster-data-handler.react.js
39–40 ↗(On Diff #45201)

Note that findUserIdentities is unchanged here

ashoat published this revision for review.Oct 15 2024, 11:28 AM
This revision is now accepted and ready to land.Oct 15 2024, 11:32 AM