[lib] Do not show sidebar underneath parent if in different tab
Needs ReviewPublic
Actions

Authored by will on Tue, Oct 15, 2:54 PM.

Tags

None

Referenced Files

	F2982158: D13720.diff
	Wed, Oct 16, 1:50 AM

	F2981702: D13720.id45212.diff
	Tue, Oct 15, 11:52 PM

	F2981587: D13720.diff
	Tue, Oct 15, 11:32 PM

	F2981527: D13720.diff
	Tue, Oct 15, 11:10 PM

	F2979249: D13720.id45212.diff
	Tue, Oct 15, 3:35 PM

	F2979206: D13720.id.diff
	Tue, Oct 15, 3:34 PM

	F2979196: D13720.diff
	Tue, Oct 15, 3:34 PM

Subscribers

tomek

Details

Reviewers

ashoat
varun

Summary

We do not wish to show the sidebars underneath the parent if they already exist as top level items in a different tab.

Depends on D13719

Test Plan

Tested by moving a child thread to a different tab and confirming that it disappeared underneath the parent thread.

Moving the parent thread to a separate tab from its child also resulted in the child disappearing from underneath.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Tue, Oct 15, 2:54 PM

Herald added a subscriber: tomek. · View Herald TranscriptTue, Oct 15, 2:54 PM

will added a child revision: D13721: [lib/native/web] Enable option to save notif tab of child threads irregardless of parent setting or sidebar type on web and native.Tue, Oct 15, 2:59 PM

Harbormaster completed remote builds in B32260: Diff 45212.Tue, Oct 15, 3:30 PM

will requested review of this revision.Tue, Oct 15, 3:30 PM

Revision Contents
Changeset List

Path

Size

lib/

selectors/

chat-selectors.js

4 lines

Diff 45212

View Options

lib/selectors/chat-selectors.js

[lib] Do not show sidebar underneath parent if in different tabNeeds ReviewPublicActions