Page MenuHomePhabricator
Differential D13727

[lib] Reduce users missing from identity
ClosedPublic
Actions

Authored by inka on Oct 16 2024, 8:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 13, 12:34 AM
Unknown Object (File)
Sat, Apr 12, 7:39 PM
Unknown Object (File)
Thu, Apr 3, 7:09 AM
Unknown Object (File)
Wed, Apr 2, 5:41 AM
Unknown Object (File)
Tue, Apr 1, 9:11 PM
Unknown Object (File)
Tue, Apr 1, 2:58 AM
Unknown Object (File)
Mar 24 2025, 3:27 AM
Unknown Object (File)
Feb 28 2025, 6:06 AM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM2f8d10eabd43: [lib] Reduce users missing from identity
Summary

issue: ENG-9631

Test Plan

Tested by dispatching setMissingDeviceListsActionType and setPeerDeviceListsActionType.
Tested that when a user is missing a device list the accountMissingStatus is set. Checked that lastChecked is updated with next requests but missingSince stays the same.

Checked that if non-empty a device list is returned by identity, accountMissingStatus is removed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
actions/
3 lines
reducers/
32 lines
types/
7 lines
5 lines

Diff 45226

View Options

lib/actions/aux-user-actions.js

// @flow // @flow
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

lib/reducers/aux-user-reducer.js

// @flow // @flow
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

lib/types/aux-user-types.js

// @flow // @flow
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };
View Options

lib/types/redux-types.js

// @flow // @flow
import type { StoreOperations } from './store-ops-types.js'; import type { StoreOperations } from './store-ops-types.js';
export type MessageSourceMetadata = { export type MessageSourceMetadata = {
+messageID: string, +messageID: string,
+senderDeviceID: string, +senderDeviceID: string,
}; };
export type DBOpsEntry = export type DBOpsEntry =
| { | {
+messageSourceMetadata: MessageSourceMetadata, +messageSourceMetadata: MessageSourceMetadata,
+ops?: ?StoreOperations, +ops?: ?StoreOperations,
} }
| { | {
+ops: StoreOperations, +ops: StoreOperations,
+dmOpID?: string,
}; };
export type DBOpsStore = { export type DBOpsStore = {
+queuedOps: $ReadOnlyArray<DBOpsEntry>, +queuedOps: $ReadOnlyArray<DBOpsEntry>,
}; };